RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1456007 - [RFE] Add support for MACsec connections to nm-connection-editor
Summary: [RFE] Add support for MACsec connections to nm-connection-editor
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Beniamino Galvani
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-26 16:34 UTC by Beniamino Galvani
Modified: 2018-04-10 13:26 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-10 13:24:24 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
[PATCH] editor: add macsec support (32.74 KB, patch)
2017-06-04 13:18 UTC, Beniamino Galvani 		no flags Details | Diff
[PATCH v2] editor: add macsec support (32.75 KB, patch)
2017-06-09 12:35 UTC, Beniamino Galvani 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0778 0 None None None 2018-04-10 13:26:21 UTC

Description Beniamino Galvani 2017-05-26 16:34:48 UTC 
nm-connection-editor should support editing MACsec connections.
Comment 2 Beniamino Galvani 2017-06-04 13:18:48 UTC 
Created attachment 1284746 [details]
[PATCH] editor: add macsec support
Comment 3 Thomas Haller 2017-06-09 08:29:10 UTC 
»···gtk_entry_set_text (priv->cak, cak);

cak and ckn are possibly NULL, triggering an assertion.

  cak ?: ""



Rest lgtm
Comment 4 Beniamino Galvani 2017-06-09 12:35:56 UTC 
Created attachment 1286405 [details]
[PATCH v2] editor: add macsec support
Comment 5 Thomas Haller 2017-06-15 21:11:51 UTC 
It looks good to me as is.




A minor nitpick, maybe you want to fix it :)

When you add a new MACSec connection, and start editing the MACsec tab...

Fill in Device and Parent (so that the "Save" tooltip no longer complains about these).

Then, change Mode to EAP. Now the tooltip says:

  Invalid setting MACsec: macsec: EAP key management requires '802-1x' setting 
  presence

Ok, so you to to the 802-1x setting, and surprisingly the checkpox is set. That is, 802-1x is enabled, although the Save tooltip still claims it isn't.
Comment 6 Francesco Giudici 2017-06-16 13:05:58 UTC 
lgtm
Comment 7 Beniamino Galvani 2017-06-18 09:36:06 UTC 
(In reply to Thomas Haller from comment #5)
> When you add a new MACSec connection, and start editing the MACsec tab...
> 
> Fill in Device and Parent (so that the "Save" tooltip no longer complains
> about these).
> 
> Then, change Mode to EAP. Now the tooltip says:
> 
>   Invalid setting MACsec: macsec: EAP key management requires '802-1x'
> setting 
>   presence
> 
> Ok, so you to to the 802-1x setting, and surprisingly the checkpox is set.
> That is, 802-1x is enabled, although the Save tooltip still claims it isn't.

Fixed, thanks.

Applied as:

https://git.gnome.org/browse/network-manager-applet/commit/?id=c481a9366320745eb8749e4e0641f8c323788e6d
Comment 11 errata-xmlrpc 2018-04-10 13:24:24 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778
Note You need to log in before you can comment on or make changes to this bug.