Bug 1456246

Summary: We do not check the base unit when creating the unit label
Product: Red Hat CloudForms Management Engine Reporter: Yaacov Zamir <yzamir>
Component: UI - OPSAssignee: Yaacov Zamir <yzamir>
Status: CLOSED CURRENTRELEASE QA Contact: brahmani
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: epacific, fsimonce, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: container:c&u
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1478379 (view as bug list) Environment:
Last Closed: 2018-03-06 14:41:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Container Management Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1478379    
Attachments:
Description Flags
Screenshot ot Tera nono secondes [Tns] unit none

Description Yaacov Zamir 2017-05-28 10:47:08 UTC
Created attachment 1282978 [details]
Screenshot ot Tera nono secondes [Tns] unit

Description of problem:
we do not check the base unit when creating the unit label

Currently we do not check the base unit when creating the unit label.
For example 1000s will become 1Ks, and 1000ms will become 1Kms.

This is wrong, we want to take into account the base units.
For example 1000s will become 1Ks, and 1000ms will become 1s.

How reproducible:
100%

Steps to Reproduce:
1. Search metrics in Ad-hoc Metrics

Actual results:
one billion ns will translate to 1Gns

Expected results:
one billion ns will translate to 1s

Additional info:

Comment 2 Yaacov Zamir 2017-05-28 10:50:14 UTC
submitted upstream:
https://github.com/ManageIQ/manageiq-ui-classic/pull/1447

Comment 3 Yaacov Zamir 2017-06-13 06:07:40 UTC
merged upstream:
https://github.com/ManageIQ/manageiq-ui-classic/pull/1447