Bug 1456246 - We do not check the base unit when creating the unit label
Summary: We do not check the base unit when creating the unit label
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.9.0
Assignee: Yaacov Zamir
QA Contact: brahmani
URL:
Whiteboard: container:c&u
Depends On:
Blocks: 1478379
TreeView+ depends on / blocked
 
Reported: 2017-05-28 10:47 UTC by Yaacov Zamir
Modified: 2018-07-15 12:34 UTC (History)
7 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1478379 (view as bug list)
Environment:
Last Closed: 2018-03-06 14:41:05 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Screenshot ot Tera nono secondes [Tns] unit (83.58 KB, image/png)
2017-05-28 10:47 UTC, Yaacov Zamir
no flags Details

Description Yaacov Zamir 2017-05-28 10:47:08 UTC
Created attachment 1282978 [details]
Screenshot ot Tera nono secondes [Tns] unit

Description of problem:
we do not check the base unit when creating the unit label

Currently we do not check the base unit when creating the unit label.
For example 1000s will become 1Ks, and 1000ms will become 1Kms.

This is wrong, we want to take into account the base units.
For example 1000s will become 1Ks, and 1000ms will become 1s.

How reproducible:
100%

Steps to Reproduce:
1. Search metrics in Ad-hoc Metrics

Actual results:
one billion ns will translate to 1Gns

Expected results:
one billion ns will translate to 1s

Additional info:

Comment 2 Yaacov Zamir 2017-05-28 10:50:14 UTC
submitted upstream:
https://github.com/ManageIQ/manageiq-ui-classic/pull/1447

Comment 3 Yaacov Zamir 2017-06-13 06:07:40 UTC
merged upstream:
https://github.com/ManageIQ/manageiq-ui-classic/pull/1447


Note You need to log in before you can comment on or make changes to this bug.