Bug 1456384

Summary: Cinder backup using NFS backend will be overwritten if same container is used
Product: Red Hat OpenStack Reporter: Gorka Eguileor <geguileo>
Component: openstack-cinderAssignee: Gorka Eguileor <geguileo>
Status: CLOSED ERRATA QA Contact: Avi Avraham <aavraham>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 10.0 (Newton)CC: aavraham, cchen, egafford, eharney, geguileo, ikedajnk, kajinamit, kawamurayus, knakai, mfuruta, pgrist, samccann, scohen, skinjo, srevivo, tbarron, vcojot
Target Milestone: z4Keywords: Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-cinder-9.1.4-4.el7ost Doc Type: Bug Fix
Doc Text:
Cause: Backups on the NFS backend shared the same "backup" prefix. Consequence: If two different backups shared the same container, the backups overwrite each other's data. Fix: Generate the backup prefix based on the backup UUID and the volume ID. Result: Backup data will no longer get overwritten.
 Story Points: ---
Clone Of: 1370932 Environment:
Last Closed: 2017-09-06 17:16:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1456381    
Bug Blocks: 1370932, 1456387    
Attachments:
Description Flags
log file from bug testing
none
volume log none

Comment 1 Red Hat Bugzilla Rules Engine 2017-05-29 09:38:24 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 2 Red Hat Bugzilla Rules Engine 2017-05-29 09:44:34 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 3 Avi Avraham 2017-06-22 12:53:30 UTC 
The fix was verified on RHOS10 system 

The relevant rpm packages ware upgraded manually on RHOS10 system 
tests ware performed as described in the bug description 
3 backup made and each backup been restored and the volume 
content was check to be as is at the time of the backup created.
Comment 4 Paul Grist 2017-06-22 13:09:21 UTC 
Many thanks Avi.  This one is approved to go out as a hotfix on OSP10 and I will start the process now.
Comment 8 Avi Avraham 2017-08-17 13:44:28 UTC 
Created attachment 1314732 [details]
log file from bug testing
Comment 9 Avi Avraham 2017-08-17 14:23:04 UTC 
Created attachment 1314739 [details]
volume log
Comment 10 Avi Avraham 2017-08-17 20:53:46 UTC 
Bug was successfully verified according to test case RHELOSP-27027
Setup Cinder backend LVM and backup backend is NFS
rpm version:
[root@controller-0 ~]# rpm -q openstack-cinder
openstack-cinder-9.1.4-6.el7ost.noarch
Comment 12 errata-xmlrpc 2017-09-06 17:16:50 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2660