Bug 1456384 - Cinder backup using NFS backend will be overwritten if same container is used
Summary: Cinder backup using NFS backend will be overwritten if same container is used
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-cinder
Version: 10.0 (Newton)
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: z4
: 10.0 (Newton)
Assignee: Gorka Eguileor
QA Contact: Avi Avraham
URL:
Whiteboard:
Depends On: 1456381
Blocks: 1370932 1456387
TreeView+ depends on / blocked
 
Reported: 2017-05-29 09:38 UTC by Gorka Eguileor
Modified: 2020-08-13 09:16 UTC (History)
17 users (show)

Fixed In Version: openstack-cinder-9.1.4-4.el7ost
Doc Type: Bug Fix
Doc Text:
Cause: Backups on the NFS backend shared the same "backup" prefix. Consequence: If two different backups shared the same container, the backups overwrite each other's data. Fix: Generate the backup prefix based on the backup UUID and the volume ID. Result: Backup data will no longer get overwritten.
Clone Of: 1370932
Environment:
Last Closed: 2017-09-06 17:16:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
log file from bug testing (2.63 MB, text/plain)
2017-08-17 13:44 UTC, Avi Avraham
no flags Details
volume log (5.11 MB, text/plain)
2017-08-17 14:23 UTC, Avi Avraham
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1628768 0 None None None 2017-05-29 09:38:02 UTC
OpenStack gerrit 413753 0 'None' ABANDONED Posix Backup: Open files w/ exclusive mode 2021-01-29 04:16:32 UTC
OpenStack gerrit 465869 0 'None' MERGED NFS Backup: Fix overwritting backups 2021-01-29 04:15:49 UTC
Red Hat Product Errata RHBA-2017:2660 0 normal SHIPPED_LIVE openstack-cinder bug fix advisory 2017-09-06 20:58:06 UTC

Comment 1 Red Hat Bugzilla Rules Engine 2017-05-29 09:38:24 UTC
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.

Comment 2 Red Hat Bugzilla Rules Engine 2017-05-29 09:44:34 UTC
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.

Comment 3 Avi Avraham 2017-06-22 12:53:30 UTC
The fix was verified on RHOS10 system 

The relevant rpm packages ware upgraded manually on RHOS10 system 
tests ware performed as described in the bug description 
3 backup made and each backup been restored and the volume 
content was check to be as is at the time of the backup created.

Comment 4 Paul Grist 2017-06-22 13:09:21 UTC
Many thanks Avi.  This one is approved to go out as a hotfix on OSP10 and I will start the process now.

Comment 8 Avi Avraham 2017-08-17 13:44:28 UTC
Created attachment 1314732 [details]
log file from bug testing

Comment 9 Avi Avraham 2017-08-17 14:23:04 UTC
Created attachment 1314739 [details]
volume log

Comment 10 Avi Avraham 2017-08-17 20:53:46 UTC
Bug was successfully verified according to test case RHELOSP-27027
Setup Cinder backend LVM and backup backend is NFS
rpm version:
[root@controller-0 ~]# rpm -q openstack-cinder
openstack-cinder-9.1.4-6.el7ost.noarch

Comment 12 errata-xmlrpc 2017-09-06 17:16:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2660


Note You need to log in before you can comment on or make changes to this bug.