Bug 1456898

Summary:	Regression test for add-brick failing with brick multiplexing enabled
Product:	[Community] GlusterFS	Reporter:	Samikshan Bairagya <sbairagy>
Component:	glusterd	Assignee:	Samikshan Bairagya <sbairagy>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1458569 (view as bug list)		Environment:
Last Closed:	2017-09-05 17:32:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1458569

Description Samikshan Bairagya 2017-05-30 16:04:52 UTC

tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t (verifies if add-brick functionality works correctly while changing the replica count simulataneously) is failing on centos machines with brick-multiplexing enabled.

Comment 1 Worker Ant 2017-05-30 16:23:40 UTC

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#1) for review on master by Samikshan Bairagya (samikshan)

Comment 2 Worker Ant 2017-05-30 16:56:40 UTC

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#2) for review on master by Samikshan Bairagya (samikshan)

Comment 3 Worker Ant 2017-05-31 13:19:10 UTC

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#3) for review on master by Samikshan Bairagya (samikshan)

Comment 4 Worker Ant 2017-06-01 10:46:42 UTC

COMMIT: https://review.gluster.org/17422 committed in master by Atin Mukherjee (amukherj) 
------
commit 6b36b162f45c4dfeb5eac21e3d77a27216e089bc
Author: Samikshan Bairagya <samikshan>
Date:   Tue May 30 18:09:01 2017 +0530

    glusterd: Fix regression wrt add-brick on replica count change
    
    tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t
    was failing on centos machines with brick multiplexing enabled.
    This is because detaching individual bricks manually from the
    backend like it is done in the regression test framework by
    'kill_brick', fails to send a RPC_CLNT_DISCONNECT to glusterd when
    multiplexing is enabled. This causes the add-brick command to not
    fail when one of the bricks are killed using kill_brick in the
    regression test framework. To fix this, set the brick status to
    GF_BRICK_STOPPED on the glusterd end during portmap signout. This
    commit also sets the brick status in glusterd_brick_stop() function
    so that the brick status is correctly set to 'stopped' even when the
    function is called independently for individual bricks.
    
    Change-Id: I4d6f7b579069d0cfa53cb2b0cff78876e1f31594
    BUG: 1456898
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: https://review.gluster.org/17422
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>
    Reviewed-by: Atin Mukherjee <amukherj>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 5 Shyamsundar 2017-09-05 17:32:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/