Bug 1458569 - Regression test for add-brick failing with brick multiplexing enabled
Summary: Regression test for add-brick failing with brick multiplexing enabled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: glusterd
Version: rhgs-3.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHGS 3.3.0
Assignee: Samikshan Bairagya
QA Contact: Bala Konda Reddy M
URL:
Whiteboard: brick-multiplexing
Depends On: 1456898
Blocks: 1417151
TreeView+ depends on / blocked
 
Reported: 2017-06-04 13:19 UTC by Atin Mukherjee
Modified: 2017-09-21 04:58 UTC (History)
7 users (show)

Fixed In Version: glusterfs-3.8.4-28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1456898
Environment:
Last Closed: 2017-09-21 04:45:37 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:2774 0 normal SHIPPED_LIVE glusterfs bug fix and enhancement update 2017-09-21 08:16:29 UTC

Description Atin Mukherjee 2017-06-04 13:19:20 UTC
+++ This bug was initially created as a clone of Bug #1456898 +++

tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t (verifies if add-brick functionality works correctly while changing the replica count simulataneously) is failing on centos machines with brick-multiplexing enabled.

--- Additional comment from Worker Ant on 2017-05-30 12:23:40 EDT ---

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#1) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2017-05-30 12:56:40 EDT ---

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#2) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2017-05-31 09:19:10 EDT ---

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#3) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2017-06-01 06:46:42 EDT ---

COMMIT: https://review.gluster.org/17422 committed in master by Atin Mukherjee (amukherj) 
------
commit 6b36b162f45c4dfeb5eac21e3d77a27216e089bc
Author: Samikshan Bairagya <samikshan>
Date:   Tue May 30 18:09:01 2017 +0530

    glusterd: Fix regression wrt add-brick on replica count change
    
    tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t
    was failing on centos machines with brick multiplexing enabled.
    This is because detaching individual bricks manually from the
    backend like it is done in the regression test framework by
    'kill_brick', fails to send a RPC_CLNT_DISCONNECT to glusterd when
    multiplexing is enabled. This causes the add-brick command to not
    fail when one of the bricks are killed using kill_brick in the
    regression test framework. To fix this, set the brick status to
    GF_BRICK_STOPPED on the glusterd end during portmap signout. This
    commit also sets the brick status in glusterd_brick_stop() function
    so that the brick status is correctly set to 'stopped' even when the
    function is called independently for individual bricks.
    
    Change-Id: I4d6f7b579069d0cfa53cb2b0cff78876e1f31594
    BUG: 1456898
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: https://review.gluster.org/17422
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>
    Reviewed-by: Atin Mukherjee <amukherj>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 2 Atin Mukherjee 2017-06-04 13:20:26 UTC
upstream patch : https://review.gluster.org/17422

Comment 5 Samikshan Bairagya 2017-06-06 11:50:22 UTC
Downstream patch: https://code.engineering.redhat.com/gerrit/#/c/108299/

Comment 7 Bala Konda Reddy M 2017-07-13 09:10:17 UTC
BUID : 3.8.4-32

Regression test for add-brick is passing now when brick mux is enabled.
Hence marking the bug as verified.

Comment 9 errata-xmlrpc 2017-09-21 04:45:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774

Comment 10 errata-xmlrpc 2017-09-21 04:58:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774


Note You need to log in before you can comment on or make changes to this bug.