Bug 1457339

Summary: DHT: slow readdirp performance
Product: [Community] GlusterFS Reporter: Raghavendra G <rgowdapp>
Component: distributeAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.11CC: bugs, nbalacha, sabansal, smohan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.11.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1356453 Environment:
Last Closed: 2017-06-28 18:31:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1356453, 1457340, 1457341    
Bug Blocks: 1356454    

Comment 1 Worker Ant 2017-05-31 14:22:13 UTC
REVIEW: https://review.gluster.org/17429 (cluster/dht: Make optimal usage of buffer provided with readdir(p)) posted (#1) for review on release-3.11 by Raghavendra G (rgowdapp)

Comment 2 Worker Ant 2017-06-06 13:10:19 UTC
COMMIT: https://review.gluster.org/17429 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 4757416dd2cd2110342f2e25e8e786d6c4b4abb2
Author: Sakshi <sabansal>
Date:   Mon Jan 23 12:11:49 2017 +0530

    cluster/dht: Make optimal usage of buffer provided with readdir(p)
    
    dht_readdirp must unwind with list of entries only after
    the entire buffer requested by kernel is filled to avoid
    extra syscalls occuring when returning partially filled
    buffer. Also wind readdir call to next subvol on reaching
    EOD for directory on that subvol to avoid extra network call.
    
    >Change-Id: If2e1a2722f813d95457c7542bff25fef56c7a041
    >BUG: 1356453
    >Signed-off-by: Sakshi <sabansal>
    >Signed-off-by: Raghavendra G <rgowdapp>
    >Reviewed-on: https://review.gluster.org/12271
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Amar Tumballi <amarts>
    >Reviewed-by: Susant Palai <spalai>
    
    (cherry picked from commit b9406e210717621bc672a63c1cbd1b0183834056)
    Change-Id: If2e1a2722f813d95457c7542bff25fef56c7a041
    BUG: 1457339
    Signed-off-by: Sakshi <sabansal>
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: https://review.gluster.org/17429
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-06-28 18:31:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.1, please open a new bug report.

glusterfs-3.11.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-June/000074.html
[2] https://www.gluster.org/pipermail/gluster-users/