Bug 1457714 (plymouth-kcm)
| Summary: | Review Request: plymouth-kcm - KCM for setting plymouth theme | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Kyral <mkyral> | ||||||
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | jgrulich, package-review, rdieter | ||||||
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2017-10-17 14:14:53 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 656997 | ||||||||
| Attachments: |
|
||||||||
|
Description
Martin Kyral
2017-06-01 07:48:32 UTC
Created attachment 1284031 [details]
spec file
Created attachment 1284033 [details]
patch to use dracut instead of update-alternatives
Spec URL: https://jgrulich.fedorapeople.org/plymouth-kcm.spec SRPM URL: https://jgrulich.fedorapeople.org/plymouth-kcm-5.10.0-0.fc27.src.rpm Uploaded to be able to use fedora-review. 1) Why don't you use %find_lang? Also listing all localization as you did in %files is not how usually this is done.
2) This "%{_libdir}/qt5/plugins/kcms/kcm_plymouth.so" can be replaced with %{_kf5_qtplugindir} if I'm not mistaken, also __provides_exclude_from should point to that location.
3) + %postun /sbin/ldconfig
Thanks for the feedback. I incorporated the proposed changes in the spec file, available in copr dist-git. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plymouth-kcm.git/tree/plymouth-kcm.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-25-x86_64/00567863-plymouth-kcm/plymouth-kcm-5.10.2-0.fc25.src.rpm Looks good to me now, note that the initial release version should be 1 and not 0. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/plymouth-kcm imported long ago, closing |