Spec URL: attached SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-rawhide-x86_64/00558567-plymouth-kcm/plymouth-kcm-5.10.0-0.fc27.src.rpm Description: This is a System Settings configuration module for configuring the plymouth splash screen. Fedora Account System Username: mkyral
Created attachment 1284031 [details] spec file
Created attachment 1284033 [details] patch to use dracut instead of update-alternatives
Spec URL: https://jgrulich.fedorapeople.org/plymouth-kcm.spec SRPM URL: https://jgrulich.fedorapeople.org/plymouth-kcm-5.10.0-0.fc27.src.rpm Uploaded to be able to use fedora-review.
1) Why don't you use %find_lang? Also listing all localization as you did in %files is not how usually this is done. 2) This "%{_libdir}/qt5/plugins/kcms/kcm_plymouth.so" can be replaced with %{_kf5_qtplugindir} if I'm not mistaken, also __provides_exclude_from should point to that location. 3) + %postun /sbin/ldconfig
Thanks for the feedback. I incorporated the proposed changes in the spec file, available in copr dist-git. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plymouth-kcm.git/tree/plymouth-kcm.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-25-x86_64/00567863-plymouth-kcm/plymouth-kcm-5.10.2-0.fc25.src.rpm
Looks good to me now, note that the initial release version should be 1 and not 0.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/plymouth-kcm
imported long ago, closing