Bug 1457725 (xdg-desktop-portal-kde)
| Summary: | Review Request: xdg-desktop-portal-kde - Qt/KF5 backend for xdg-desktop-portal | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Kyral <mkyral> | ||||
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jgrulich, package-review, rdieter | ||||
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-10-17 14:14:24 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 656997 | ||||||
| Attachments: |
|
||||||
|
Description
Martin Kyral
2017-06-01 07:59:51 UTC
Created attachment 1285795 [details]
spec file
Spec URL: https://jgrulich.fedorapeople.org/xdg-desktop-portal-kde.spec SRPM URL: https://jgrulich.fedorapeople.org/xdg-desktop-portal-kde-5.10.0-0.fc27.src.rpm Uploaded to be able to use fedora-review. 1) Why don't you use %find_lang? Also listing all localization as you did in %files is not how usually this is done.
2) I think this can be removed
# filter plugin provides
%global __provides_exclude_from ^(%{_kf5_plugindir}/.*\\.so)$
Other than that it looks fine, fix please mentioned issues.
Thanks for the feedback. I incorporated the proposed changes in the spec file, available in copr dist-git. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/xdg-desktop-portal-kde.git/tree/xdg-desktop-portal-kde.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-25-x86_64/00567865-xdg-desktop-portal-kde/xdg-desktop-portal-kde-5.10.2-0.fc25.src.rpm Just minor things that can be done during import. The initial release version should be 1 and not 0. Also you can remove %post section in this case. Other than that it looks good. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xdg-desktop-portal-kde imported long ago |