Spec URL: attached SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-rawhide-x86_64/00559489-xdg-desktop-portal-kde/xdg-desktop-portal-kde-5.10.0-0.fc27.src.rpm Description: A backend implementation for xdg-desktop-portal that is using Qt/KF5 and various pieces of KDE infrastructure. Fedora Account System Username: mkyral
Created attachment 1285795 [details] spec file
Spec URL: https://jgrulich.fedorapeople.org/xdg-desktop-portal-kde.spec SRPM URL: https://jgrulich.fedorapeople.org/xdg-desktop-portal-kde-5.10.0-0.fc27.src.rpm Uploaded to be able to use fedora-review.
1) Why don't you use %find_lang? Also listing all localization as you did in %files is not how usually this is done. 2) I think this can be removed # filter plugin provides %global __provides_exclude_from ^(%{_kf5_plugindir}/.*\\.so)$ Other than that it looks fine, fix please mentioned issues.
Thanks for the feedback. I incorporated the proposed changes in the spec file, available in copr dist-git. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/xdg-desktop-portal-kde.git/tree/xdg-desktop-portal-kde.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-25-x86_64/00567865-xdg-desktop-portal-kde/xdg-desktop-portal-kde-5.10.2-0.fc25.src.rpm
Just minor things that can be done during import. The initial release version should be 1 and not 0. Also you can remove %post section in this case. Other than that it looks good.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xdg-desktop-portal-kde
imported long ago