Bug 1457754

Summary:	Use of the new create_service_provision_request method is inconsistent with other create_*_request methods
Product:	Red Hat CloudForms Management Engine	Reporter:	Peter McGowan <pmcgowan>
Component:	Automate	Assignee:	Greg McCullough <gmccullo>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	fdupont, jhardy, mkanoor, obarenbo, tfitzger
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	service:provision
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1461144 (view as bug list)		Environment:
Last Closed:	2018-03-06 14:39:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1461144

Description Peter McGowan 2017-06-01 09:04:50 UTC

Description of problem:
The new create_service_provision_request method is called directly from $evm, however the 2 'sibling' methods create_automation_request and create_provision_request are called via $evm.execute. This is inconsistent and potentially confusing.

Suggest we move create_service_provision_request into MiqAeServiceMethods for consistency.

Version-Release number of selected component (if applicable):
5.8.0.16

How reproducible:
every time

Comment 2 Greg McCullough 2017-06-12 13:48:37 UTC

Fixed in PRs:
https://github.com/ManageIQ/manageiq-automation_engine/pull/34
https://github.com/ManageIQ/manageiq-content/pull/126

Comment 7 Milan Falešník 2017-10-18 11:58:29 UTC

Verified in 5.9.0.2 using https://bugzilla.redhat.com/show_bug.cgi?id=1461144#c4