Bug 1457754 - Use of the new create_service_provision_request method is inconsistent with other create_*_request methods
Summary: Use of the new create_service_provision_request method is inconsistent with o...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Greg McCullough
QA Contact: Dmitry Misharov
URL:
Whiteboard: service:provision
Depends On:
Blocks: 1461144
TreeView+ depends on / blocked
 
Reported: 2017-06-01 09:04 UTC by Peter McGowan
Modified: 2018-05-29 13:41 UTC (History)
5 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1461144 (view as bug list)
Environment:
Last Closed: 2018-03-06 14:39:07 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github https://github.com/ManageIQ manageiq-automation_engine issues 33 0 None None None 2017-06-02 08:32:57 UTC

Description Peter McGowan 2017-06-01 09:04:50 UTC 
Description of problem:
The new create_service_provision_request method is called directly from $evm, however the 2 'sibling' methods create_automation_request and create_provision_request are called via $evm.execute. This is inconsistent and potentially confusing.

Suggest we move create_service_provision_request into MiqAeServiceMethods for consistency.

Version-Release number of selected component (if applicable):
5.8.0.16

How reproducible:
every time
Comment 2 Greg McCullough 2017-06-12 13:48:37 UTC 
Fixed in PRs:
https://github.com/ManageIQ/manageiq-automation_engine/pull/34
https://github.com/ManageIQ/manageiq-content/pull/126
Comment 7 Milan Falešník 2017-10-18 11:58:29 UTC 
Verified in 5.9.0.2 using https://bugzilla.redhat.com/show_bug.cgi?id=1461144#c4
Note You need to log in before you can comment on or make changes to this bug.