Bug 1457758
| Summary: | lastpass-cli: Do not interpose reallocarray in /usr/bin/lpass | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | lastpass-cli | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 27 | CC: | eclipseo, fweimer, tom.prince |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lastpass-cli-1.3.1-2.fc27 lastpass-cli-1.3.1-2.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-12 13:46:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1457749 | ||
|
Description
Florian Weimer
2017-06-01 09:10:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'. (In reply to Florian Weimer from comment #0) > /usr/bin/lpass defines the reallocarray symbol, which is also provided by > glibc. Please use the function from glibc, rather than supplying your own. > A > simple recompile against current rawhide might be sufficient, depending on > the > build-time feature detection logic in the package. I've just inherited this package. How can I check if lpass still defines the reallocarray symbol? I have no idea how to proceed. You can look at the output of eu-readelf --symbols=.dynsym /usr/bin/lpass and see if it does not list reallocarray at all, or lists it with UNDEF. In both cases, the local (exported/interposing) definition will be gone. It is listed but not with UNDEF: 201: 0000000000020e30 82 FUNC GLOBAL DEFAULT 14 reallocarray despite the rebuild. It seems they implement it in util.c: https://github.com/lastpass/lastpass-cli/blob/master/util.c#L199 What can I do about that exactly? (In reply to Robert-André Mauchin from comment #4) > It is listed but not with UNDEF: > > 201: 0000000000020e30 82 FUNC GLOBAL DEFAULT 14 reallocarray > > despite the rebuild. > > > It seems they implement it in util.c: > > https://github.com/lastpass/lastpass-cli/blob/master/util.c#L199 > > What can I do about that exactly? You could perhaps remove it in a patch. Ok patched it and now I have: 119: 0000000000000000 0 FUNC GLOBAL DEFAULT UNDEF reallocarray (11) So it should be good. I will push updates ASAP. Thanks for your help. lastpass-cli-1.3.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ea0c4938b5 lastpass-cli-1.3.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b92047374c lastpass-cli-1.3.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b92047374c lastpass-cli-1.3.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ea0c4938b5 lastpass-cli-1.3.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. lastpass-cli-1.3.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |