Bug 1457758 - lastpass-cli: Do not interpose reallocarray in /usr/bin/lpass
Summary: lastpass-cli: Do not interpose reallocarray in /usr/bin/lpass
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lastpass-cli
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora27GlibcInterpositionTracker
TreeView+ depends on / blocked
 
Reported: 2017-06-01 09:10 UTC by Florian Weimer
Modified: 2018-07-13 17:32 UTC (History)
3 users (show)

Fixed In Version: lastpass-cli-1.3.1-2.fc27 lastpass-cli-1.3.1-2.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-12 13:46:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2017-06-01 09:10:55 UTC
/usr/bin/lpass defines the reallocarray symbol, which is also provided by
glibc.  Please use the function from glibc, rather than supplying your own.  A
simple recompile against current rawhide might be sufficient, depending on the
build-time feature detection logic in the package.

Comment 1 Jan Kurik 2017-08-15 07:43:49 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 2 Robert-André Mauchin 🐧 2018-07-02 23:07:00 UTC
(In reply to Florian Weimer from comment #0)
> /usr/bin/lpass defines the reallocarray symbol, which is also provided by
> glibc.  Please use the function from glibc, rather than supplying your own. 
> A
> simple recompile against current rawhide might be sufficient, depending on
> the
> build-time feature detection logic in the package.

I've just inherited this package. How can I check if lpass still defines the reallocarray symbol? I have no idea how to proceed.

Comment 3 Florian Weimer 2018-07-03 11:11:07 UTC
You can look at the output of

eu-readelf --symbols=.dynsym /usr/bin/lpass

and see if it does not list reallocarray at all, or lists it with UNDEF.  In both cases, the local (exported/interposing) definition will be gone.

Comment 4 Robert-André Mauchin 🐧 2018-07-03 12:45:03 UTC
It is listed but not with UNDEF:

  201: 0000000000020e30     82 FUNC    GLOBAL DEFAULT       14 reallocarray

despite the rebuild.


It seems they implement it in util.c:

https://github.com/lastpass/lastpass-cli/blob/master/util.c#L199

What can I do about that exactly?

Comment 5 Florian Weimer 2018-07-03 12:49:12 UTC
(In reply to Robert-André Mauchin from comment #4)
> It is listed but not with UNDEF:
> 
>   201: 0000000000020e30     82 FUNC    GLOBAL DEFAULT       14 reallocarray
> 
> despite the rebuild.
> 
> 
> It seems they implement it in util.c:
> 
> https://github.com/lastpass/lastpass-cli/blob/master/util.c#L199
> 
> What can I do about that exactly?

You could perhaps remove it in a patch.

Comment 6 Robert-André Mauchin 🐧 2018-07-03 18:29:37 UTC
Ok patched it and now I have:

  119: 0000000000000000      0 FUNC    GLOBAL DEFAULT    UNDEF reallocarray (11)


So it should be good. I will push updates ASAP.

Thanks for your help.

Comment 7 Fedora Update System 2018-07-03 18:59:37 UTC
lastpass-cli-1.3.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ea0c4938b5

Comment 8 Fedora Update System 2018-07-03 19:25:04 UTC
lastpass-cli-1.3.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b92047374c

Comment 9 Fedora Update System 2018-07-04 16:22:45 UTC
lastpass-cli-1.3.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b92047374c

Comment 10 Fedora Update System 2018-07-04 18:21:36 UTC
lastpass-cli-1.3.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ea0c4938b5

Comment 11 Fedora Update System 2018-07-12 13:46:51 UTC
lastpass-cli-1.3.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2018-07-13 17:32:04 UTC
lastpass-cli-1.3.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.