Bug 1457812

Summary: extras/hook-scripts: non-portable shell syntax (debian package maintainer)
Product: [Community] GlusterFS Reporter: Kaleb KEITHLEY <kkeithle>
Component: scriptsAssignee: Kaleb KEITHLEY <kkeithle>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, nigelb, vbellur
Target Milestone: ---Keywords: Reopened, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.12.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1459095 (view as bug list) Environment:
Last Closed: 2018-11-19 06:58:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1459095    

Description Kaleb KEITHLEY 2017-06-01 11:04:37 UTC
Description of problem:

use of "function" is not portable to other shells

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-06-01 11:08:09 UTC
REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable shell syntax (debian package maintainer)) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2017-06-01 12:03:22 UTC
REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable shell syntax (debian package maintainer)) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Worker Ant 2017-06-02 11:41:30 UTC
REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable shell syntax) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 4 Worker Ant 2017-06-02 12:13:38 UTC
COMMIT: https://review.gluster.org/17443 committed in master by Niels de Vos (ndevos) 
------
commit be28cbc5f8d3a78f6968b0307d001a5c0f0d8b31
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Jun 1 07:05:42 2017 -0400

    extras/hookscripts: non-portable shell syntax
    
    use of "function" is not portable to other shells
    
    Reported-by: Patrick Matthäi <pmatthaei>
    Change-Id: I13a0482b387cc3b7a7a57df424e673850603da37
    BUG: 1457812
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/17443
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>

Comment 5 Worker Ant 2017-07-03 14:32:46 UTC
REVIEW: https://review.gluster.org/17681 (extras/hooks: non-portable shell syntax) posted (#1) for review on master by Nigel Babu (nigelb)

Comment 6 Worker Ant 2017-07-14 03:54:34 UTC
REVIEW: https://review.gluster.org/17681 (extras/hooks: non-portable shell syntax) posted (#2) for review on master by Nigel Babu (nigelb)

Comment 7 Worker Ant 2017-07-14 11:27:56 UTC
REVIEW: https://review.gluster.org/17681 (extras/hooks: non-portable shell syntax) posted (#3) for review on master by Nigel Babu (nigelb)

Comment 8 Worker Ant 2017-07-25 10:18:11 UTC
REVIEW: https://review.gluster.org/17681 (extras/hooks: non-portable shell syntax) posted (#4) for review on master by Nigel Babu (nigelb)

Comment 9 Shyamsundar 2017-09-05 17:32:34 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 10 Nigel Babu 2017-09-06 05:22:10 UTC
The associated patch is not merged in.

Comment 11 Vijay Bellur 2018-11-19 06:58:44 UTC
Closing this bug as https://review.gluster.org/#/c/glusterfs/+/18485/ addresses the issue.