Bug 1459095 - extras/hook-scripts: non-portable shell syntax (debian package maintainer)
Summary: extras/hook-scripts: non-portable shell syntax (debian package maintainer)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: scripts
Version: 3.11
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On: 1457812
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-06 09:30 UTC by Kaleb KEITHLEY
Modified: 2017-06-28 18:32 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.1
Clone Of: 1457812
Environment:
Last Closed: 2017-06-28 18:32:26 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2017-06-06 09:30:09 UTC
+++ This bug was initially created as a clone of Bug #1457812 +++

Description of problem:

use of "function" is not portable to other shells

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-06-01 07:08:09 EDT ---

REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable shell syntax (debian package maintainer)) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Worker Ant on 2017-06-01 08:03:22 EDT ---

REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable shell syntax (debian package maintainer)) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Worker Ant on 2017-06-02 07:41:30 EDT ---

REVIEW: https://review.gluster.org/17443 (extras/hookscripts: non-portable shell syntax) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Worker Ant on 2017-06-02 08:13:38 EDT ---

COMMIT: https://review.gluster.org/17443 committed in master by Niels de Vos (ndevos) 
------
commit be28cbc5f8d3a78f6968b0307d001a5c0f0d8b31
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Jun 1 07:05:42 2017 -0400

    extras/hookscripts: non-portable shell syntax
    
    use of "function" is not portable to other shells
    
    Reported-by: Patrick Matthäi <pmatthaei>
    Change-Id: I13a0482b387cc3b7a7a57df424e673850603da37
    BUG: 1457812
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/17443
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-06-06 09:34:35 UTC
REVIEW: https://review.gluster.org/17476 (extras/hookscripts: non-portable shell syntax) posted (#1) for review on release-3.11 by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2017-06-06 19:23:15 UTC
COMMIT: https://review.gluster.org/17476 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 9570e226bac30da7dd487fdecb88c608876dfe96
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Jun 1 07:05:42 2017 -0400

    extras/hookscripts: non-portable shell syntax
    
    use of "function" is not portable to other shells
    
    master BUG: 1457812
    master: https://review.gluster.org/17443
    
    Reported-by: Patrick Matthäi <pmatthaei>
    Change-Id: I13a0482b387cc3b7a7a57df424e673850603da37
    BUG: 1459095
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/17476
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-06-28 18:32:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.1, please open a new bug report.

glusterfs-3.11.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-June/000074.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.