Bug 1457914
| Summary: | [3.4] upgrade get applied to all nodes if openshift_upgrade_nodes_label fits no label | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Carsten Lichy-Bittendorf <clichybi> | |
| Component: | Cluster Version Operator | Assignee: | Russell Teague <rteague> | |
| Status: | CLOSED ERRATA | QA Contact: | Anping Li <anli> | |
| Severity: | high | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 3.4.1 | CC: | aos-bugs, jokerman, mmccomas, pdwyer | |
| Target Milestone: | --- | |||
| Target Release: | 3.4.z | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: |
Verifies the provided label matches a set of hosts prior to upgrading. If the label didn't match hosts, the upgrade would silently proceed with upgrading all nodes given the logic for creating the oo_nodes_to_upgrade group.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1462992 1462995 (view as bug list) | Environment: | ||
| Last Closed: | 2017-06-29 13:33:14 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
Proposed for 3.6: https://github.com/openshift/openshift-ansible/pull/4498 Proposed for 3.4: https://github.com/openshift/openshift-ansible/pull/4500 The expected message is reported. so move to verified.
TASK [Fail if no nodes match openshift_upgrade_nodes_label] ********************
fatal: [openshift-225.lab.eng.nay.redhat.com]: FAILED! => {
"changed": false,
"failed": true
}
MSG:
openshift_upgrade_nodes_label was specified but no nodes matched
to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_4/upgrade_nodes.retry
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:1666 |
Description of problem: running the upgrade playbook with option 'openshift_upgrade_nodes_label' all nodes get migrated if no label matches. This is very risky as due to a typo suddenly all nodes could get migrated at once. Version-Release number of selected component (if applicable): ocp 3.4.1.24 How reproducible: Steps to Reproduce: 1. Setup OCP 3.3 cluster 2. try to upgrade a single node by running: ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_4/upgrade_nodes.yml \ -e openshift_upgrade_nodes_serial='100%' \ -e openshift_upgrade_nodes_label='kubernetes.io/hostname=some.hostneme.which.doesn't.fit' Actual results: all nodes get migrated Expected results: no node should get migrated, if no label matches Additional info: