Description of problem: running the upgrade playbook with option 'openshift_upgrade_nodes_label' all nodes get migrated if no label matches. This is very risky as due to a typo suddenly all nodes could get migrated at once. Version-Release number of selected component (if applicable): ocp 3.4.1.24 How reproducible: Steps to Reproduce: 1. Setup OCP 3.3 cluster 2. try to upgrade a single node by running: ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_4/upgrade_nodes.yml \ -e openshift_upgrade_nodes_serial='100%' \ -e openshift_upgrade_nodes_label='kubernetes.io/hostname=some.hostneme.which.doesn't.fit' Actual results: all nodes get migrated Expected results: no node should get migrated, if no label matches Additional info:
Proposed for 3.6: https://github.com/openshift/openshift-ansible/pull/4498
Proposed for 3.4: https://github.com/openshift/openshift-ansible/pull/4500
Merged: https://github.com/openshift/openshift-ansible/pull/4500
The expected message is reported. so move to verified. TASK [Fail if no nodes match openshift_upgrade_nodes_label] ******************** fatal: [openshift-225.lab.eng.nay.redhat.com]: FAILED! => { "changed": false, "failed": true } MSG: openshift_upgrade_nodes_label was specified but no nodes matched to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_4/upgrade_nodes.retry
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:1666