Bug 1458569

+++ This bug was initially created as a clone of Bug #1456898 +++

tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t (verifies if add-brick functionality works correctly while changing the replica count simulataneously) is failing on centos machines with brick-multiplexing enabled.

--- Additional comment from Worker Ant on 2017-05-30 12:23:40 EDT ---

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#1) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2017-05-30 12:56:40 EDT ---

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#2) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2017-05-31 09:19:10 EDT ---

REVIEW: https://review.gluster.org/17422 (glusterd: Fix regression wrt add-brick on replica count change) posted (#3) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2017-06-01 06:46:42 EDT ---

COMMIT: https://review.gluster.org/17422 committed in master by Atin Mukherjee (amukherj) 
------
commit 6b36b162f45c4dfeb5eac21e3d77a27216e089bc
Author: Samikshan Bairagya <samikshan>
Date:   Tue May 30 18:09:01 2017 +0530

    glusterd: Fix regression wrt add-brick on replica count change
    
    tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t
    was failing on centos machines with brick multiplexing enabled.
    This is because detaching individual bricks manually from the
    backend like it is done in the regression test framework by
    'kill_brick', fails to send a RPC_CLNT_DISCONNECT to glusterd when
    multiplexing is enabled. This causes the add-brick command to not
    fail when one of the bricks are killed using kill_brick in the
    regression test framework. To fix this, set the brick status to
    GF_BRICK_STOPPED on the glusterd end during portmap signout. This
    commit also sets the brick status in glusterd_brick_stop() function
    so that the brick status is correctly set to 'stopped' even when the
    function is called independently for individual bricks.
    
    Change-Id: I4d6f7b579069d0cfa53cb2b0cff78876e1f31594
    BUG: 1456898
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: https://review.gluster.org/17422
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>
    Reviewed-by: Atin Mukherjee <amukherj>
    CentOS-regression: Gluster Build System <jenkins.org>