Bug 1459051

Summary: disable-multipath script should not disable & stop multipathd
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: SATHEESARAN <sasundar>
Component: gdeployAssignee: Sachidananda Urs <surs>
Status: CLOSED ERRATA QA Contact: SATHEESARAN <sasundar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rhgs-3.2CC: amukherj, rhinduja, rhs-bugs, smohan, storage-qa-internal
Target Milestone: ---   
Target Release: RHGS 3.3.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gdeploy-2.0.2-11 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-21 04:49:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1411323, 1417151, 1485863    

Description SATHEESARAN 2017-06-06 07:55:41 UTC
Description of problem:
-----------------------
The script that gdeploy uses to blacklist the devices, stops & disabled multipathd.
This script is expected **only** to blacklist the local devices

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
gdeploy-2.0.1-13.el7rhgs
gdeploy-2.0.2-10.el7rhgs

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Run 'disable-multipath.sh'

Actual results:
---------------
multipathd is stopped and disabled

Expected results:
-----------------
multipathd should not be stopped and disabled

Additional info:
----------------
# cat /usr/share/ansible/gdeploy/scripts/disable-multipath.sh 
#!/usr/bin/env bash

multipath -F
cat <<EOF>> /etc/multipath.conf
blacklist {
        devnode "*"
}
EOF

systemctl stop multipathd
systemctl disable multipathd

Comment 1 SATHEESARAN 2017-06-06 07:59:44 UTC
Also the name of the script should be changed from 'disable_multipath.sh' to 'blacklist_all_disks.sh', otherwise this is going to misleading the users

Comment 4 Sachidananda Urs 2017-06-16 07:21:13 UTC
Commit: https://github.com/gluster/gdeploy/commit/9adca82 should fix the issue.

Comment 5 SATHEESARAN 2017-07-11 10:56:32 UTC
Tested with gdeploy-2.0.2-12.el7rhgs

The script 'disable_multipath.sh' doesn't disables and stops multipathd.
Also the script is now renamed to 'blacklist_all_disks.sh'

Comment 8 errata-xmlrpc 2017-09-21 04:49:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2777