Bug 1459051 - disable-multipath script should not disable & stop multipathd
disable-multipath script should not disable & stop multipathd
Status: CLOSED ERRATA
Product: Red Hat Gluster Storage
Classification: Red Hat
Component: gdeploy (Show other bugs)
3.2
x86_64 Linux
unspecified Severity medium
: ---
: RHGS 3.3.0
Assigned To: Sachidananda Urs
SATHEESARAN
:
Depends On:
Blocks: Gluster-HC-3 RHHI-1.1-Approved-Backlog-BZs 1417151
  Show dependency treegraph
 
Reported: 2017-06-06 03:55 EDT by SATHEESARAN
Modified: 2017-09-21 00:49 EDT (History)
5 users (show)

See Also:
Fixed In Version: gdeploy-2.0.2-11
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-09-21 00:49:50 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description SATHEESARAN 2017-06-06 03:55:41 EDT
Description of problem:
-----------------------
The script that gdeploy uses to blacklist the devices, stops & disabled multipathd.
This script is expected **only** to blacklist the local devices

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
gdeploy-2.0.1-13.el7rhgs
gdeploy-2.0.2-10.el7rhgs

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Run 'disable-multipath.sh'

Actual results:
---------------
multipathd is stopped and disabled

Expected results:
-----------------
multipathd should not be stopped and disabled

Additional info:
----------------
# cat /usr/share/ansible/gdeploy/scripts/disable-multipath.sh 
#!/usr/bin/env bash

multipath -F
cat <<EOF>> /etc/multipath.conf
blacklist {
        devnode "*"
}
EOF

systemctl stop multipathd
systemctl disable multipathd
Comment 1 SATHEESARAN 2017-06-06 03:59:44 EDT
Also the name of the script should be changed from 'disable_multipath.sh' to 'blacklist_all_disks.sh', otherwise this is going to misleading the users
Comment 4 Sachidananda Urs 2017-06-16 03:21:13 EDT
Commit: https://github.com/gluster/gdeploy/commit/9adca82 should fix the issue.
Comment 5 SATHEESARAN 2017-07-11 06:56:32 EDT
Tested with gdeploy-2.0.2-12.el7rhgs

The script 'disable_multipath.sh' doesn't disables and stops multipathd.
Also the script is now renamed to 'blacklist_all_disks.sh'
Comment 8 errata-xmlrpc 2017-09-21 00:49:50 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2777

Note You need to log in before you can comment on or make changes to this bug.