Bug 1459816

Summary: Origin info shows incorrect when convert guest from disk to rhv by virt-v2v
Product: Red Hat Enterprise Linux 7 Reporter: mxie <mxie>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED NOTABUG QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 7.4CC: juzhou, mzhan, ptoscano, tgolembi, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: V2V
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-15 15:09:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1460519    
Bug Blocks:    
Attachments:
Description Flags
screenshot none

Description mxie@redhat.com 2017-06-08 09:25:34 UTC
Created attachment 1286089 [details]
screenshot

Description of problem:
Origin info shows incorrect when convert guest from disk to rhv by virt-v2v  

Version-Release number of selected component (if applicable):
libguestfs-1.36.3-4.el7.x86_64
virt-v2v-1.36.3-4.el7.x86_64
qemu-kvm-rhev-2.9.0-8.el7.x86_64
libvirt-3.2.0-7.el7.x86_64



How reproducible:
100%

Steps to Reproduce:
1.Prepare a disk which has installed os on virt-v2v conversion server

2.Using virt-v2v to convert this disk to rhv
# virt-v2v -i disk xen-pv-rhel6.9-x86_64-sda -o rhv -os 10.73.131.93:/home/nfs_export -if qcow2
[   0.0] Opening the source -i disk -if qcow2 xen-pv-rhel6.9-x86_64-sda
[   0.0] Creating an overlay to protect the source from being modified
[   0.1] Initializing the target -o rhv -os 10.73.131.93:/home/nfs_export
[   0.4] Opening the overlay
[   1.5] Inspecting the overlay
[  11.3] Checking for sufficient free disk space in the guest
[  11.3] Estimating space required on target for each disk
[  11.3] Converting Red Hat Enterprise Linux Server release 6.9 (Santiago) to run on KVM
virt-v2v: warning: /files/boot/grub/device.map/hd0 references unknown
device "vda".  You may have to fix this entry manually after conversion.
virt-v2v: warning: /files/etc/sysconfig/grub/boot references unknown device
"vda".  You may have to fix this entry manually after conversion.
virt-v2v: This guest has virtio drivers installed.
[  85.7] Mapping filesystem data to avoid copying unused and blank areas
[  85.8] Closing the overlay
[  86.0] Checking if the guest needs BIOS or UEFI to boot
[  86.0] Assigning disks to buses
[  86.0] Copying disk 1/1 to /tmp/v2v.kMgJ6I/4f699f1d-7f77-4e73-a0d2-a3b73c1a0c29/images/af8b2af7-57a4-43ee-9a2f-f6e63525a785/325b50b7-6db3-43d3-9a52-d69649cf0110 (qcow2)
    (100.00/100%)
[ 147.4] Creating output metadata
[ 147.5] Finishing off

3.After finishing conversion, import the guest from data domain to export domain
4.Found the origin info shows "RHV"

Actual results:
As above description

Expected results:
Origin info should be KVM when convert guest from disk to rhv by virt-v2v  

Additional info:
1.Can't reproduce the problem when convert guest from libvirtxml to rhv or convert guest to rhv directly by virt-v2v
2.Could reproduce the problem after downgrading virt-v2v to 1.36.3-1.el7.x86_64 or virt-v2v-1.32.7.el7.x86_64,so it is not regression problem

Comment 2 Richard W.M. Jones 2017-06-08 09:29:43 UTC
This could be a regression of bug 1342398.

Comment 3 Pino Toscano 2017-06-09 13:42:54 UTC
When using -i disk, we internally set the hypervisor type to UnknownHV, which makes no <Origin> created in the output OVF.
Considering that in ovirt-engine.git, backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OriginType.java, the RHEV enum value has value 0, which IIRC is the default value for int in Java.

Also, IMHO -i disk shouldn't set KVM as origin type, since there is nothing that says the disk image comes from a KVM setup. The other alternative could be adding a simple --disk-origin parameter to v2v, so users can tweak that value, in case it is needed.

Comment 4 Tomáš Golembiovský 2017-06-11 19:42:08 UTC
It seems you're experiencing what I have described in bug 1342398, comment 8. The reason for that is exactly what Pino said.

I didn't open a bug for that before so it slipped from everyone's mind I guess.
I've opened a new bug 1460519 to track that.

Comment 5 Pino Toscano 2019-04-15 15:09:26 UTC
This is not a virt-v2v issue: virt-v2v specifies the Origin when known, which is not when importing from disk.
A better handling of this in RHV was a better solution, but unfortunately bug 1460519 was closed as WONTFIX.

Thus, I'm closing this bug as NOTABUG, since there was no issue in virt-v2v.