Bug 1459927

Summary:	rich rules are only syntax-checked, invalid rules are silently unapplied
Product:	Red Hat Enterprise Linux 7	Reporter:	Tomas Dolezal <todoleza>
Component:	firewalld	Assignee:	Eric Garver <egarver>
Status:	CLOSED ERRATA	QA Contact:	Jiri Peska <jpeska>
Severity:	high	Docs Contact:
Priority:	medium
Version:	7.4	CC:	atragler, jmaxwell, jpeska, rkhan, sukulkar, todoleza
Target Milestone:	rc	Keywords:	TestOnly
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	firewalld-0.6.3-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-31 20:00:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1637204
Bug Blocks:	1472751

Description Tomas Dolezal 2017-06-08 15:12:00 UTC

Description of problem:
firewall-cmd --add-rich-rule 'rule service name=rainbowpony log'
The error is printed solely in syslog as
WARNING: INVALID_SERVICE: rainbowpony
this information is very useful for admin to see in the moment of rule creation

Version-Release number of selected component (if applicable):
firewalld-0.4.4.4-5.el7.noarch

How reproducible:
always

Steps to Reproduce:
firewall-cmd --add-rich-rule 'rule service name=rainbowpony log'


Actual results:
"success" is printed out

Expected results:
this output:
WARNING: INVALID_SERVICE: rainbowpony
success

Additional info:
should be similar to
Warning: ALREADY_ENABLED: 'rule service name="network-unreachable" log' already in 'public'
success

Comment 4 Eric Garver 2018-10-08 21:48:46 UTC

Fixed upstream:

    cc0fadae1eb5 ("fw_zone: do not change rich rule errors into warnings")

# firewall-cmd --add-rich-rule 'rule service name=rainbowpony log'
Error: INVALID_SERVICE: rainbowpony

Comment 10 errata-xmlrpc 2020-03-31 20:00:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1109