Bug 1460402

Summary:	libreswan mistakenly does not allow repeated CERT / CERTREQ payloads in IKEv2
Product:	Red Hat Enterprise Linux 7	Reporter:	Paul Wouters <pwouters>
Component:	libreswan	Assignee:	Paul Wouters <pwouters>
Status:	CLOSED ERRATA	QA Contact:	Ondrej Moriš <omoris>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.3	CC:	ffotorel, glamb, lmiksik, mmezynsk, omoris, pwouters, santony
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	3.20-2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 12:31:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paul Wouters 2017-06-09 22:59:07 UTC

Description of problem:

"tunnel-XXXX" #768: payload (ISAKMP_NEXT_v2CERT) unexpectedly repeated. Message dropped.

This affects all versions of libreswan up to 3.18, so RHEL-7.3 packages have this issue as well. All versions of openswan are affected as well.

The current (prerelease) build for RHEL-7.4 which is based on 3.20 contains the fix for this issue.

Comment 1 Paul Wouters 2017-06-09 23:00:57 UTC

The code change is in ikev2.c:

Old code:

static const lset_t repeatable_payloads = P(N) | P(D) | P(CP) | P(V); 

New code:

static const lset_t repeatable_payloads = P(N) | P(D) | P(CP) | P(V) | P(CERT) | P(CERTREQ);

Comment 10 Ondrej Moriš 2017-06-22 07:38:57 UTC

Cannot reproduce this issue. Verified SanityOnly with libreswan-3.20-3.el7.

Comment 11 errata-xmlrpc 2017-08-01 12:31:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2101