Bug 1460617

Summary: failed expects first param is a list when run upgrade_etcd.yml
Product: OpenShift Container Platform Reporter: Anping Li <anli>
Component: Cluster Version OperatorAssignee: Jan Chaloupka <jchaloup>
Status: CLOSED ERRATA QA Contact: Anping Li <anli>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.6.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-10 05:26:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Anping Li 2017-06-12 08:32:57 UTC
Description of problem:
run upgrade_etcd.yml failed.

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.98

How reproducible:
always

Steps to Reproduce:
1. install OCP v3.6 with etcd-3.1.3-1.el7.x86_64
2. run playbook upgrade_etcd.yml

Actual results:
PLAYBOOK: upgrade_etcd.yml *****************************************************
17 plays in /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml

PLAY [Create initial host groups for localhost] ********************************

TASK [include_vars] ************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/initialize_groups.yml:10
ok: [localhost] => {
    "ansible_facts": {
        "g_all_hosts": "{{ g_master_hosts | union(g_node_hosts) | union(g_etcd_hosts) | union(g_lb_hosts) | union(g_nfs_hosts) | union(g_new_node_hosts)| union(g_new_master_hosts) | default([]) }}", 
        "g_etcd_hosts": "{{ groups.etcd | default([]) }}", 
        "g_glusterfs_hosts": "{{ groups.glusterfs | default([]) }}", 
        "g_glusterfs_registry_hosts": "{{ groups.glusterfs_registry | default(g_glusterfs_hosts) }}", 
        "g_lb_hosts": "{{ groups.lb | default([]) }}", 
        "g_master_hosts": "{{ groups.masters | default([]) }}", 
        "g_new_master_hosts": "{{ groups.new_masters | default([]) }}", 
        "g_new_node_hosts": "{{ groups.new_nodes | default([]) }}", 
        "g_nfs_hosts": "{{ groups.nfs | default([]) }}", 
        "g_node_hosts": "{{ groups.nodes | default([]) }}"
    }, 
    "changed": false
}

PLAY [Gate on etcd backup] *****************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [set_fact] ****************************************************************
task path: /usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/etcd/backup.yml:18
fatal: [localhost]: FAILED! => {
    "failed": true
}

MSG:

|failed expects first param is a list
	to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.retry

PLAY RECAP *********************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=1   


Expected results:


Additional info:

Comment 1 Scott Dodson 2017-06-26 13:48:05 UTC
Can this still be reproduced with current code?

Comment 2 Anping Li 2017-06-27 02:35:58 UTC
++ docker run -it -v /root/etcd-single:/root/workdir:rw -v /root/.ssh:/root/configdir:ro ose-ansible:v3.6 oo_play /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml
atomic-openshift-utils-3.6.124-1.git.0.507a059.el7.noarch
ansible-playbook --private-key /root/configdir/libra.pem -i /root/workdir/hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.yml

PLAY [Create initial host groups for localhost] ********************************

TASK [include_vars] ************************************************************
ok: [localhost]

PLAY [Gate on etcd backup] *****************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [set_fact] ****************************************************************
fatal: [localhost]: FAILED! => {
    "failed": true
}

MSG:

|failed expects first param is a list
	to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/upgrade_etcd.retry

PLAY RECAP *********************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=1

Comment 4 Jan Chaloupka 2017-06-28 11:26:35 UTC
Upstream PR: https://github.com/openshift/openshift-ansible/pull/4619

Comment 5 Jan Chaloupka 2017-06-28 12:12:26 UTC
Merged upstream

Comment 7 Anping Li 2017-07-04 02:46:08 UTC
The playbook succeed, so move to verified.
TASK [etcd_common : Display location of etcd backup] ***************************
ok: [openshift-208.lab.eng.nay.redhat.com] => {}

MSG:

Etcd backup created in /var/lib/etcd//openshift-backup-etcd_backup_tag20170704104444


PLAY [Gate on etcd backup] *****************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [set_fact] ****************************************************************
ok: [localhost]

TASK [set_fact] ****************************************************************
ok: [localhost]

TASK [fail] ********************************************************************
skipping: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=18   changed=0    unreachable=0    failed=0   
openshift-208.lab.eng.nay.redhat.com : ok=80   changed=6    unreachable=0    failed=0

Comment 9 errata-xmlrpc 2017-08-10 05:26:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716