Bug 1460619

Summary: vdsm insert gaps in the ifcfg file for every network update
Product: [oVirt] vdsm Reporter: Michael Burman <mburman>
Component: CoreAssignee: Edward Haas <edwardh>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.19.18CC: bugs, eedri, stirabos
Target Milestone: ovirt-4.1.4Flags: rule-engine: ovirt-4.1+
Target Release: 4.19.21   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-28 14:10:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Burman 2017-06-12 08:40:41 UTC 
Description of problem:
vdsm insert gaps in the ifcfg file for every network update.

For every network update, for example MTU, vdsm insert new gap in the ifcfg file.
After few updates, you will have a huge gap in the ifcfg file.

For exmaple -

[root@orchid-vds2 ~]# cat /etc/sysconfig/network-scripts/ifcfg-mb1 
# Generated by VDSM version 4.19.17-1.el7ev
DEVICE=mb1
TYPE=Bridge
DELAY=0
STP=off
ONBOOT=yes
DEFROUTE=no
NM_CONTROLLED=no
IPV6INIT=no





MTU=1500[root@orchid-vds2 ~]# 
 

# Generated by VDSM version 4.19.17-1.el7ev
DEVICE=mb1
TYPE=Bridge
DELAY=0
STP=off
ONBOOT=yes
DEFROUTE=no
NM_CONTROLLED=no
IPV6INIT=no





MTU=1500


Version-Release number of selected component (if applicable):
vdsm-4.19.18-1.el7ev.x86_64
 4.1.3.2-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Attach network to host
2. Via 'Networks' tab update the network with custom MTU=9000
3. Update the network back to default MTU=1500
4. Continue steps 2 and 3 few times, update the network with MTU

Actual results:
Huge gap in the ifcfg-* file.
For every MTU update, new gap line is added in the ifcfg file

Expected results:
No gaps should be generated by vdsm into the ifcfg files
Comment 1 rhev-integ 2017-07-07 12:23:59 UTC 
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'v4.19.21' doesn't contain patch 'https://gerrit.ovirt.org/78900']
gitweb: https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=shortlog;h=refs/tags/v4.19.21

For more info please contact: infra
Comment 2 Eyal Edri 2017-07-10 12:29:59 UTC 
The patch is in the v4.19.21 tag and we've identified an issue with moving vdsm bugs to ON_QA on last build, the problem will be fixed by next build.
Comment 3 Michael Burman 2017-07-10 13:02:19 UTC 
Verified on - vdsm-4.19.21-1.el7ev.x86_64