Bug 1460619 - vdsm insert gaps in the ifcfg file for every network update
Summary: vdsm insert gaps in the ifcfg file for every network update
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.19.18
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-4.1.4
: 4.19.21
Assignee: Edward Haas
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-12 08:40 UTC by Michael Burman
Modified: 2017-07-28 14:10 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-07-28 14:10:50 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 78890 0 master MERGED net: Unneeded newline is added when updating only the mtu 2017-07-03 12:28:18 UTC
oVirt gerrit 78900 0 ovirt-4.1 MERGED net: Unneeded newline is added when updating only the mtu 2017-07-04 07:59:35 UTC

Description Michael Burman 2017-06-12 08:40:41 UTC
Description of problem:
vdsm insert gaps in the ifcfg file for every network update.

For every network update, for example MTU, vdsm insert new gap in the ifcfg file.
After few updates, you will have a huge gap in the ifcfg file.

For exmaple -

[root@orchid-vds2 ~]# cat /etc/sysconfig/network-scripts/ifcfg-mb1 
# Generated by VDSM version 4.19.17-1.el7ev
DEVICE=mb1
TYPE=Bridge
DELAY=0
STP=off
ONBOOT=yes
DEFROUTE=no
NM_CONTROLLED=no
IPV6INIT=no





MTU=1500[root@orchid-vds2 ~]# 
 

# Generated by VDSM version 4.19.17-1.el7ev
DEVICE=mb1
TYPE=Bridge
DELAY=0
STP=off
ONBOOT=yes
DEFROUTE=no
NM_CONTROLLED=no
IPV6INIT=no





MTU=1500


Version-Release number of selected component (if applicable):
vdsm-4.19.18-1.el7ev.x86_64
 4.1.3.2-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Attach network to host
2. Via 'Networks' tab update the network with custom MTU=9000
3. Update the network back to default MTU=1500
4. Continue steps 2 and 3 few times, update the network with MTU

Actual results:
Huge gap in the ifcfg-* file.
For every MTU update, new gap line is added in the ifcfg file

Expected results:
No gaps should be generated by vdsm into the ifcfg files

Comment 1 rhev-integ 2017-07-07 12:23:59 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'v4.19.21' doesn't contain patch 'https://gerrit.ovirt.org/78900']
gitweb: https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=shortlog;h=refs/tags/v4.19.21

For more info please contact: infra

Comment 2 Eyal Edri 2017-07-10 12:29:59 UTC
The patch is in the v4.19.21 tag and we've identified an issue with moving vdsm bugs to ON_QA on last build, the problem will be fixed by next build.

Comment 3 Michael Burman 2017-07-10 13:02:19 UTC
Verified on - vdsm-4.19.21-1.el7ev.x86_64


Note You need to log in before you can comment on or make changes to this bug.