Bug 1462790

Summary:	with AFR now making both nodes to return UUID for a file will result in georep consuming more resources
Product:	[Community] GlusterFS	Reporter:	Karthik U S <ksubrahm>
Component:	replicate	Assignee:	Karthik U S <ksubrahm>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, aspandey, bugs, ksubrahm, nbalacha, nchilaka, ravishankar, rhs-bugs, sheggodu, storage-qa-internal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1462693
Clones:	1463250 1487647 (view as bug list)		Environment:
Last Closed:	2017-08-23 09:58:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1315781, 1462693, 1463250, 1464078, 1487647

Comment 1 Worker Ant 2017-06-19 14:47:10 UTC

REVIEW: https://review.gluster.org/17576 (cluster/afr: Returning single and list of node uuids from AFR) posted (#1) for review on master by Karthik U S (ksubrahm)

Comment 2 Worker Ant 2017-06-20 06:21:29 UTC

REVIEW: https://review.gluster.org/17576 (cluster/afr: Returning single and list of node uuids from AFR) posted (#2) for review on master by Karthik U S (ksubrahm)

Comment 3 Worker Ant 2017-06-20 12:32:14 UTC

COMMIT: https://review.gluster.org/17576 committed in master by Jeff Darcy (jeff.us) 
------
commit 475ec9928ef96b63a0bfa859a9ae68709275033c
Author: karthik-us <ksubrahm>
Date:   Mon Jun 19 19:54:36 2017 +0530

    cluster/afr: Returning single and list of node uuids from AFR
    
    Problem:
    The change in afr to return list of node uuids was causing problems
    with geo-rep.
    
    Fix:
    This patch will allow to get the single node uuid as it was doing
    before with the key "GF_XATTR_NODE_UUID_KEY", and will also allow
    to get the list of node uuids by using a new key
    "GF_XATTR_LIST_NODE_UUIDS_KEY". This will solve the problem with
    geo-rep and any other feature which were depending on this.
    
    Change-Id: I09885dac6dfca127be94b708470c8c2941356f9a
    BUG: 1462790
    Signed-off-by: karthik-us <ksubrahm>
    Reviewed-on: https://review.gluster.org/17576
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Kotresh HR <khiremat>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 4 Worker Ant 2017-06-20 13:26:03 UTC

REVIEW: https://review.gluster.org/17581 (cluster/afr: Reverting the change https://review.gluster.org/#/c/17576/) posted (#1) for review on master by Karthik U S (ksubrahm)

Comment 5 Worker Ant 2017-06-20 15:03:01 UTC

REVIEW: https://review.gluster.org/17582 (geo-rep: Updated node-uuid xattr parser for new format) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 6 Worker Ant 2017-06-21 11:24:25 UTC

REVIEW: https://review.gluster.org/17594 (cluster/ec: Node uuid xattr support update for EC) posted (#1) for review on master by Sunil Kumar Acharya (sheggodu)

Comment 7 Worker Ant 2017-06-22 07:26:16 UTC

REVIEW: https://review.gluster.org/17594 (cluster/ec: Node uuid xattr support update for EC) posted (#2) for review on master by Sunil Kumar Acharya (sheggodu)

Comment 8 Worker Ant 2017-06-22 12:15:15 UTC

REVIEW: https://review.gluster.org/17594 (cluster/ec: Node uuid xattr support update for EC) posted (#3) for review on master by Sunil Kumar Acharya (sheggodu)

Comment 9 Worker Ant 2017-06-22 12:34:52 UTC

REVIEW: https://review.gluster.org/17594 (cluster/ec: Node uuid xattr support update for EC) posted (#4) for review on master by Sunil Kumar Acharya (sheggodu)

Comment 10 Worker Ant 2017-06-23 02:56:39 UTC

COMMIT: https://review.gluster.org/17594 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 0c0bc42ddfef4f05b50c3d1510e93ef3ec292a56
Author: Sunil Kumar Acharya <sheggodu>
Date:   Wed Jun 21 16:37:09 2017 +0530

    cluster/ec: Node uuid xattr support update for EC
    
    Problem:
    The change in EC to return list of node uuids for
    GF_XATTR_NODE_UUID_KEY was causing problems with
    geo-rep.
    
    Fix:
    This patch will allow to get the single node uuid
    as it was doing before with the key
    "GF_XATTR_NODE_UUID_KEY", and will also allow to get
    the list of node uuids by using a new key
    "GF_XATTR_LIST_NODE_UUIDS_KEY". This will solve
    the problem with geo-rep and any other features which
    were depending on this.
    
    BUG: 1462790
    Change-Id: I2d9214a9658d4a41a3d6de08600884d2bda5f3eb
    Signed-off-by: Sunil Kumar Acharya <sheggodu>
    Reviewed-on: https://review.gluster.org/17594
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Xavier Hernandez <xhernandez>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 11 Shyamsundar 2017-09-05 17:34:44 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/