Bug 1462992

Summary: [3.6] upgrade get applied to all nodes if openshift_upgrade_nodes_label fits no label
Product: OpenShift Container Platform Reporter: Russell Teague <rteague>
Component: Cluster Version OperatorAssignee: Russell Teague <rteague>
Status: CLOSED ERRATA QA Contact: Anping Li <anli>
Severity: high Docs Contact:
Priority: medium    
Version: 3.6.0CC: anli, aos-bugs, clichybi, jmalde, jokerman, mmccomas, pdwyer, rteague
Target Milestone: ---Keywords: Reopened
Target Release: 3.6.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Verifies the provided label matches a set of hosts prior to upgrading. If the label didn't match hosts, the upgrade would silently proceed with upgrading all nodes given the logic for creating the oo_nodes_to_upgrade group.
Story Points: ---
Clone Of: 1457914 Environment:
Last Closed: 2018-05-24 12:48:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Russell Teague 2017-06-19 20:03:17 UTC
Proposed for 3.6: https://github.com/openshift/openshift-ansible/pull/4498

Comment 2 Russell Teague 2017-06-22 15:31:26 UTC
Merged: https://github.com/openshift/openshift-ansible/pull/4498

Comment 4 Anping Li 2017-06-26 08:16:47 UTC
The fix work well with openshift-ansible-3.6.124


TASK [Fail if no nodes match openshift_upgrade_nodes_label] ********************
fatal: [openshift-225.lab.eng.nay.redhat.com]: FAILED! => {
    "changed": false, 
    "failed": true
}

MSG:

openshift_upgrade_nodes_label was specified but no nodes matched
	to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade.retry

PLAY RECAP *********************************************************************
localhost                  : ok=11   changed=0    unreachable=0    failed=0   
openshift-208.lab.eng.nay.redhat.com : ok=24   changed=0    unreachable=0    failed=0   
openshift-225.lab.eng.nay.redhat.com : ok=27   changed=0    unreachable=0    failed=1

Comment 6 errata-xmlrpc 2017-08-10 05:28:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716

Comment 9 Scott Dodson 2018-05-24 12:48:29 UTC
We don't re-open bugs that have shipped an errata. Please open a new bug with just the details of the problem you've observed along with complete inventory and logs.