Bug 1464316

Summary:	DHT: Pass errno as an argument to gf_msg
Product:	[Community] GlusterFS	Reporter:	ankit <anraj>
Component:	distribute	Assignee:	ankit <anraj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.11	CC:	anraj, bugs, nbalacha
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1454701
Clones:	1464317 (view as bug list)		Environment:
Last Closed:	2017-08-12 13:07:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1454701
Bug Blocks:	1464317

Description ankit 2017-06-23 05:11:53 UTC

+++ This bug was initially created as a clone of Bug #1454701 +++

Description of problem:
Several calls to gf_msg in the dht-rebalance.c file do not pass the errno as an argument to the gf_msg call. Instead strerror(errno) becomes part of the message.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:

The errno (where available) should be passed as an arg to gf_msg which will automatically print the err string.

Additional info:

--- Additional comment from Worker Ant on 2017-06-05 04:47:30 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#1) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-05 07:35:30 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#2) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-06 03:14:10 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#3) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-06 05:01:23 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#4) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-06 05:17:37 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#5) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-06 05:27:47 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#6) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-19 12:25:40 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#7) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-19 22:17:23 EDT ---

REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#8) for review on master by ankitraj

--- Additional comment from Worker Ant on 2017-06-20 08:32:03 EDT ---

COMMIT: https://review.gluster.org/17464 committed in master by Jeff Darcy (jeff.us) 
------
commit ee9a2f01adb6c089f4579c5e0b7f5eed335dd0df
Author: AnkitRaj <anraj>
Date:   Mon Jun 5 14:11:43 2017 +0530

    dht: passing the errno as an argument to gf_msg
    
    There are many calls in gf_msg where errno
    is needed to pass as an argument instead of
    strerrno(error)
    
    Change-Id: I15048a5e0b41f9752a2023afe8470eca6f2cd383
    Bug: 1454701
    Signed-off-by: AnkitRaj <anraj>
    Reviewed-on: https://review.gluster.org/17464
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: MOHIT AGRAWAL <moagrawa>
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: N Balachandran <nbalacha>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Karthik U S <ksubrahm>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 1 Worker Ant 2017-06-23 05:15:52 UTC

REVIEW: https://review.gluster.org/17616 (dht: passing the errno as an argument to gf_msg) posted (#1) for review on release-3.11 by ankitraj

Comment 2 Worker Ant 2017-07-05 14:22:13 UTC

COMMIT: https://review.gluster.org/17616 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 1e69cf94c047b12f6cb257939910ab29cdf5b011
Author: AnkitRaj <anraj>
Date:   Mon Jun 5 14:11:43 2017 +0530

    dht: passing the errno as an argument to gf_msg
    
    There are many calls in gf_msg where errno
    is needed to pass as an argument instead of
    strerrno(error)
    
    Backport of https://review.gluster.org/#/c/17464/
    
    Change-Id: I15048a5e0b41f9752a2023afe8470eca6f2cd383
    Bug: 1464316
    Signed-off-by: AnkitRaj <anraj>
    Reviewed-on: https://review.gluster.org/17464
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: MOHIT AGRAWAL <moagrawa>
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: N Balachandran <nbalacha>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Karthik U S <ksubrahm>
    Reviewed-by: Jeff Darcy <jeff.us>
    Signed-off-by: ankitraj <anraj>
    Reviewed-on: https://review.gluster.org/17616
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-08-12 13:07:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.2, please open a new bug report.

glusterfs-3.11.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-July/031908.html
[2] https://www.gluster.org/pipermail/gluster-users/