+++ This bug was initially created as a clone of Bug #1464316 +++ +++ This bug was initially created as a clone of Bug #1454701 +++ Description of problem: Several calls to gf_msg in the dht-rebalance.c file do not pass the errno as an argument to the gf_msg call. Instead strerror(errno) becomes part of the message. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: The errno (where available) should be passed as an arg to gf_msg which will automatically print the err string. Additional info: --- Additional comment from Worker Ant on 2017-06-05 04:47:30 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#1) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-05 07:35:30 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#2) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-06 03:14:10 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#3) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-06 05:01:23 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#4) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-06 05:17:37 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#5) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-06 05:27:47 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#6) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-19 12:25:40 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#7) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-19 22:17:23 EDT --- REVIEW: https://review.gluster.org/17464 (dht: passing the errno as an argument to gf_msg) posted (#8) for review on master by ankitraj --- Additional comment from Worker Ant on 2017-06-20 08:32:03 EDT --- COMMIT: https://review.gluster.org/17464 committed in master by Jeff Darcy (jeff.us) ------ commit ee9a2f01adb6c089f4579c5e0b7f5eed335dd0df Author: AnkitRaj <anraj> Date: Mon Jun 5 14:11:43 2017 +0530 dht: passing the errno as an argument to gf_msg There are many calls in gf_msg where errno is needed to pass as an argument instead of strerrno(error) Change-Id: I15048a5e0b41f9752a2023afe8470eca6f2cd383 Bug: 1454701 Signed-off-by: AnkitRaj <anraj> Reviewed-on: https://review.gluster.org/17464 Smoke: Gluster Build System <jenkins.org> Reviewed-by: MOHIT AGRAWAL <moagrawa> Reviewed-by: N Balachandran <nbalacha> Tested-by: N Balachandran <nbalacha> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Karthik U S <ksubrahm> Reviewed-by: Jeff Darcy <jeff.us>
REVIEW: https://review.gluster.org/17646 (dht: passing the errno as an argument to gf_msg) posted (#1) for review on release-3.10 by ankitraj
REVIEW: https://review.gluster.org/17646 (dht: passing the errno as an argument to gf_msg) posted (#2) for review on release-3.10 by ankitraj
REVIEW: https://review.gluster.org/17646 (dht: passing the errno as an argument to gf_msg) posted (#3) for review on release-3.10 by ankitraj
This bug reported is against a version of Gluster that is no longer maintained (or has been EOL'd). See https://www.gluster.org/release-schedule/ for the versions currently maintained. As a result this bug is being closed. If the bug persists on a maintained version of gluster or against the mainline gluster repository, request that it be reopened and the Version field be marked appropriately.