Bug 1464904
| Summary: | [RFE] snapshot/rollback support for restoring managed state | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> | ||||||
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 7.4 | CC: | atragler, bgalvani, fgiudici, lrintel, rkhan, salmy, sukulkar, thaller | ||||||
| Target Milestone: | rc | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-04-10 13:27:23 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1294549 [details]
[PATCH] checkpoint: better restore device managed state on rollback
(In reply to Beniamino Galvani from comment #1) > Created attachment 1294549 [details] > [PATCH] checkpoint: better restore device managed state on rollback + NM_UNMANAGED_USER_EXPLICIT, + NM_UNMAN_FLAG_OP_SET_MANAGED, + NM_DEVICE_STATE_REASON_NOW_UNMANAGED); the reason seems wrong. for certain unmanaged flags (especially USER_EXPLICIT), it makes a difference whether the flag is unspecified. See _get_managed_by_flags(). You should only touch the USER_EXPLICIT flag, if nm_device_get_unmanaged_mask() indicates that the flag is already set. Probably, dev_checkpoint->unmanaged_explicit should not be boolean but tri-state (NMUnmanFlagOp). Created attachment 1301079 [details] [PATCH v2] checkpoint: better restore device managed state on rollback (In reply to Thomas Haller from comment #2) > the reason seems wrong. > Probably, dev_checkpoint->unmanaged_explicit should not be boolean but > tri-state (NMUnmanFlagOp). How about v2? v2 lgtm Applied to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=67bfdbfc9189856dd7428d27f7d8fbe9c2ee7446 nm-1-8: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=nm-1-8&id=fb5834c3c1e4bcdf9003b50382f920959a8447b4 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0778 |
Description of problem: Now NM can restore unmanaged state but not the other way. this works: @snapshot_rollback_unmanaged Scenario: NM - general - snapshot and rollback unmanaged * Execute "nmcli device set eth1 managed off" * Snapshot "create" for "eth1" with timeout "10" * Execute "nmcli device set eth1 managed on" When "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds * Wait for at least "15" seconds Then "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds but this doesn't: @snapshot_rollback_unmanaged Scenario: NM - general - snapshot and rollback managed * Snapshot "create" for "eth1" with timeout "10" * Execute "nmcli device set eth1 managed off" When "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds * Wait for at least "15" seconds Then "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds Version-Release number of selected component (if applicable): 1.8.0