RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1464904 - [RFE] snapshot/rollback support for restoring managed state
Summary: [RFE] snapshot/rollback support for restoring managed state
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Beniamino Galvani
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-26 08:36 UTC by Vladimir Benes
Modified: 2018-04-10 13:28 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-10 13:27:23 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
[PATCH] checkpoint: better restore device managed state on rollback (1.67 KB, patch)
2017-07-05 11:51 UTC, Beniamino Galvani 		no flags Details | Diff
[PATCH v2] checkpoint: better restore device managed state on rollback (2.97 KB, patch)
2017-07-19 12:22 UTC, Beniamino Galvani 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0778 0 None None None 2018-04-10 13:28:55 UTC

Description Vladimir Benes 2017-06-26 08:36:14 UTC 
Description of problem:
Now NM can restore unmanaged state but not the other way. 

this works:
    @snapshot_rollback_unmanaged
    Scenario: NM - general - snapshot and rollback unmanaged
    * Execute "nmcli device set eth1 managed off"
    * Snapshot "create" for "eth1" with timeout "10"
    * Execute "nmcli device set eth1 managed on"
    When "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds
    * Wait for at least "15" seconds
    Then "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds

but this doesn't:
    @snapshot_rollback_unmanaged
    Scenario: NM - general - snapshot and rollback managed
    * Snapshot "create" for "eth1" with timeout "10"
    * Execute "nmcli device set eth1 managed off"
    When "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds
    * Wait for at least "15" seconds
    Then "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds


Version-Release number of selected component (if applicable):
1.8.0
Comment 1 Beniamino Galvani 2017-07-05 11:51:55 UTC 
Created attachment 1294549 [details]
[PATCH] checkpoint: better restore device managed state on rollback
Comment 2 Thomas Haller 2017-07-07 14:06:33 UTC 
(In reply to Beniamino Galvani from comment #1)
> Created attachment 1294549 [details]
> [PATCH] checkpoint: better restore device managed state on rollback

+                         NM_UNMANAGED_USER_EXPLICIT,
+                         NM_UNMAN_FLAG_OP_SET_MANAGED,
+                         NM_DEVICE_STATE_REASON_NOW_UNMANAGED);

the reason seems wrong.

for certain unmanaged flags (especially USER_EXPLICIT), it makes a difference whether the flag is unspecified. See _get_managed_by_flags(). You should only touch the USER_EXPLICIT flag, if nm_device_get_unmanaged_mask() indicates that the flag is already set.
Probably, dev_checkpoint->unmanaged_explicit should not be boolean but tri-state (NMUnmanFlagOp).
Comment 3 Beniamino Galvani 2017-07-19 12:22:57 UTC 
Created attachment 1301079 [details]
[PATCH v2] checkpoint: better restore device managed state on rollback

(In reply to Thomas Haller from comment #2)
> the reason seems wrong.

> Probably, dev_checkpoint->unmanaged_explicit should not be boolean but
> tri-state (NMUnmanFlagOp).

How about v2?
Comment 4 Thomas Haller 2017-08-18 15:39:48 UTC 
v2 lgtm
Comment 5 Beniamino Galvani 2017-08-28 08:47:02 UTC 
Applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=67bfdbfc9189856dd7428d27f7d8fbe9c2ee7446

nm-1-8:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=nm-1-8&id=fb5834c3c1e4bcdf9003b50382f920959a8447b4
Comment 9 errata-xmlrpc 2018-04-10 13:27:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778
Note You need to log in before you can comment on or make changes to this bug.