Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
Now NM can restore unmanaged state but not the other way.
this works:
@snapshot_rollback_unmanaged
Scenario: NM - general - snapshot and rollback unmanaged
* Execute "nmcli device set eth1 managed off"
* Snapshot "create" for "eth1" with timeout "10"
* Execute "nmcli device set eth1 managed on"
When "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds
* Wait for at least "15" seconds
Then "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds
but this doesn't:
@snapshot_rollback_unmanaged
Scenario: NM - general - snapshot and rollback managed
* Snapshot "create" for "eth1" with timeout "10"
* Execute "nmcli device set eth1 managed off"
When "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds
* Wait for at least "15" seconds
Then "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds
Version-Release number of selected component (if applicable):
1.8.0
Comment 1Beniamino Galvani
2017-07-05 11:51:55 UTC
(In reply to Beniamino Galvani from comment #1)
> Created attachment 1294549[details]
> [PATCH] checkpoint: better restore device managed state on rollback
+ NM_UNMANAGED_USER_EXPLICIT,
+ NM_UNMAN_FLAG_OP_SET_MANAGED,
+ NM_DEVICE_STATE_REASON_NOW_UNMANAGED);
the reason seems wrong.
for certain unmanaged flags (especially USER_EXPLICIT), it makes a difference whether the flag is unspecified. See _get_managed_by_flags(). You should only touch the USER_EXPLICIT flag, if nm_device_get_unmanaged_mask() indicates that the flag is already set.
Probably, dev_checkpoint->unmanaged_explicit should not be boolean but tri-state (NMUnmanFlagOp).
Comment 3Beniamino Galvani
2017-07-19 12:22:57 UTC
Created attachment 1301079[details]
[PATCH v2] checkpoint: better restore device managed state on rollback
(In reply to Thomas Haller from comment #2)
> the reason seems wrong.> Probably, dev_checkpoint->unmanaged_explicit should not be boolean but
> tri-state (NMUnmanFlagOp).
How about v2?
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHBA-2018:0778
Description of problem: Now NM can restore unmanaged state but not the other way. this works: @snapshot_rollback_unmanaged Scenario: NM - general - snapshot and rollback unmanaged * Execute "nmcli device set eth1 managed off" * Snapshot "create" for "eth1" with timeout "10" * Execute "nmcli device set eth1 managed on" When "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds * Wait for at least "15" seconds Then "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds but this doesn't: @snapshot_rollback_unmanaged Scenario: NM - general - snapshot and rollback managed * Snapshot "create" for "eth1" with timeout "10" * Execute "nmcli device set eth1 managed off" When "unmanaged" is visible with command "nmcli device show eth1" in "5" seconds * Wait for at least "15" seconds Then "unmanaged" is not visible with command "nmcli device show eth1" in "5" seconds Version-Release number of selected component (if applicable): 1.8.0