Bug 1467551
| Summary: | default value for openshift_service_catalog_image_prefix are set incorrectly | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Johnny Liu <jialiu> |
| Component: | Installer | Assignee: | Scott Dodson <sdodson> |
| Status: | CLOSED ERRATA | QA Contact: | Johnny Liu <jialiu> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.6.0 | CC: | aos-bugs, jokerman, mmccomas |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: |
undefined
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-10 05:29:50 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
https://github.com/openshift/openshift-ansible/pull/4664 will fix the prefix but we don't have '3.6.0' as a tag. So I've added 'v3.6' to the additional tags for the build and I think we should switch to using that. https://github.com/openshift/openshift-ansible/pull/4679 PR seem good to me, but I have one more request, is it possible to remove "registry.access.redhat.com/" from __openshift_service_catalog_image_prefix, so that allow user to easy to pull image from different registry according to openshift_docker_additional_registries setting, especially for QE's testing. @scott, I saw you also committed ab749692e5136b6ec05c647a04cc4e3e39a663eb for fully qualify ocp ansible_service_broker_image_prefix, if possible, could you revert it. I like the original behavior for the reason just like comment 4. We use a fully qualified prefix in metrics, logging, and registry-console. We're also trying to move away from relating on the --additional-registries behavior because it produces unpredictable results in a scenario where your additional registries happen to be down you may retrieve content from another registry. Verified this bug with openshift-ansible-3.6.135-1.git.0.5533fe3.el7.noarch.rpm, and PASS. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1716 |
Description of problem: In roles/openshift_service_catalog/templates/api_server.j2, it is trying to use the following image: <--snip--> image: {{ openshift_service_catalog_image_prefix }}service-catalog:{{ openshift_service_catalog_image_version }} <--snip--> In roles/openshift_service_catalog/tasks/install.yml, <--snip--> - name: Set service_catalog image facts set_fact: openshift_service_catalog_image_prefix: "{{ openshift_service_catalog_image_prefix | default(__openshift_service_catalog_image_prefix) }}" openshift_service_catalog_image_version: "{{ openshift_service_catalog_image_version | default(__openshift_service_catalog_image_version) }}" <--snip--> In roles/openshift_service_catalog/vars/openshift-enterprise.yml, <--snip--> __openshift_service_catalog_image_prefix: "registry.access.redhat.com/openshift3/" __openshift_service_catalog_image_version: "3.6.0" <--snip--> That means catalog image path would be like: registry.access.redhat.com/openshift3/service-catalog:3.6.0 While as far as I know, the image path would be like openshift3/ose-service-catalog, because I only could get openshift3/ose-service-catalog from OSBS. So suggest the default value for __openshift_service_catalog_image_prefix should be set to "registry.access.redhat.com/openshift3/ose-" Version-Release number of selected component (if applicable): openshift-ansible-roles-3.6.132-1.git.0.0d0f54a.el7.noarch How reproducible: Always Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: