Bug 1467995

Summary: Review Request: python-slackclient - Slack Developer Kit for Python
Product: [Fedora] Fedora Reporter: Gwyn Ciesla <gwync>
Component: Package ReviewAssignee: Randy Barlow <randy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, randy
Target Milestone: ---Flags: randy: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-14 13:23:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
review.txt none

Description Gwyn Ciesla 2017-07-05 18:12:53 UTC 
Description: Slack Developer Kit for Python.

SPEC: https://fedorapeople.org/~limb/review/python-slackclient/python-slackclient.spec
SRPM: https://fedorapeople.org/~limb/review/python-slackclient/python-slackclient-1.0.6-1.fc26.src.rpm
Comment 1 Randy Barlow 2017-07-05 21:20:24 UTC 
Created attachment 1294743 [details]
review.txt
Comment 2 Randy Barlow 2017-07-05 21:21:44 UTC 
Approved! I have two suggestions for improvement, but they are optional so feel free to ignore:

136 [!]: It would be nice to package the docs/ folder. I have no idea how they
137      are intended to be built, but you could just package the rst files
138      since rst is pretty human readable. 
139 [!]: It'd be reasonable to drop the shebang on the _client.py file to get
140      rid of the rpmlint errors. You could also run dos2unix on the
141      README.rst to fix its line endings.

If you have some time and wouldn't mind doing a review for me, I could use review on this one:

https://bugzilla.redhat.com/show_bug.cgi?id=1467417
Comment 3 Gwyn Ciesla 2017-07-06 12:41:31 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-slackclient
Comment 4 Gwyn Ciesla 2017-07-06 12:43:20 UTC 
Thank you!  Looks like Dan beat me to 1467417, I can do another if you have one.
Comment 5 Fedora Update System 2017-07-06 13:09:18 UTC 
python-slackclient-1.0.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb2f5d9307
Comment 6 Randy Barlow 2017-07-06 14:06:43 UTC 
Thanks for the offer! I don't have any more Python packages waiting for review right now. If you are comfortable with a JavaScript package I've got this one:

https://bugzilla.redhat.com/show_bug.cgi?id=1421480
Comment 7 Gwyn Ciesla 2017-07-06 14:15:21 UTC 
I'll give it a go.
Comment 8 Fedora Update System 2017-07-06 18:23:39 UTC 
python-slackclient-1.0.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb2f5d9307
Comment 9 Fedora Update System 2017-07-14 13:23:10 UTC 
python-slackclient-1.0.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.