Description: Slack Developer Kit for Python. SPEC: https://fedorapeople.org/~limb/review/python-slackclient/python-slackclient.spec SRPM: https://fedorapeople.org/~limb/review/python-slackclient/python-slackclient-1.0.6-1.fc26.src.rpm
Created attachment 1294743 [details] review.txt
Approved! I have two suggestions for improvement, but they are optional so feel free to ignore: 136 [!]: It would be nice to package the docs/ folder. I have no idea how they 137 are intended to be built, but you could just package the rst files 138 since rst is pretty human readable. 139 [!]: It'd be reasonable to drop the shebang on the _client.py file to get 140 rid of the rpmlint errors. You could also run dos2unix on the 141 README.rst to fix its line endings. If you have some time and wouldn't mind doing a review for me, I could use review on this one: https://bugzilla.redhat.com/show_bug.cgi?id=1467417
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-slackclient
Thank you! Looks like Dan beat me to 1467417, I can do another if you have one.
python-slackclient-1.0.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb2f5d9307
Thanks for the offer! I don't have any more Python packages waiting for review right now. If you are comfortable with a JavaScript package I've got this one: https://bugzilla.redhat.com/show_bug.cgi?id=1421480
I'll give it a go.
python-slackclient-1.0.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb2f5d9307
python-slackclient-1.0.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.