Bug 1468339
| Summary: | [RFE][L-8] Integration with external Ansible Tower Workflows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ryan Spagnola <rspagnol> | ||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Nandini Chandra <nachandr> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.8.0 | CC: | aarrichi, awyatt, bsorota, cpelland, dberger, dluong, ekin.meroglu, gblomqui, greartes, hkataria, ignacio, jfrey, jhardy, jmarc, jocarter, jritenou, jwong, kmorey, lavenel, mburgerh, mfeifer, mpovolny, niroy, obarenbo, simaishi, smallamp, vestival | ||||
| Target Milestone: | MVP | Keywords: | FutureFeature, RFE | ||||
| Target Release: | 5.10.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.10.0.11 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-02-07 23:02:36 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Feature | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | Ansible | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1590440, 1590441, 1590975 | ||||||
| Bug Blocks: | 1555371, 1590058 | ||||||
| Attachments: |
|
||||||
|
Description
Ryan Spagnola
2017-07-06 18:14:48 UTC
Hi John, Assigning this RFE to you for evaluation. Thanks Bronagh Created attachment 1331487 [details]
Logs showing failure to launch tower job using workflow name.
Evm log shows inventory detecting the wokflow name (Install Apache & Update), but not adding it to job template inventory.
Automation log shows the failed job trying to force instantiate a workflow using ansible_tower_job.
I attached logs from my environment - CF does not include the workflows in job template inventory syncs, and trying to instantiate a workflow using ansible_tower_job request results in the following: [----] E, [2017-09-27T12:13:15.947308 #27111:c2829c] ERROR -- : Q-task_id([resource_action_20000000001132]) <AEMethod launch_ansible_job> The following error occurred during method evaluation: [----] E, [2017-09-27T12:13:15.948797 #27111:c2829c] ERROR -- : Q-task_id([resource_action_20000000001132]) <AEMethod launch_ansible_job> RuntimeError: Job Template not specified [----] E, [2017-09-27T12:13:15.949837 #27111:c2829c] ERROR -- : Q-task_id([resource_action_20000000001132]) <AEMethod launch_ansible_job> /ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/ Job/launch_ansible_job:75:in `job_template' /ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/Job/launch_ansible_job:20:in `main' [----] E, [2017-09-27T12:13:15.953928 #27111:c2829c] ERROR -- : Q-task_id([resource_action_20000000001132]) Method STDERR: /ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/Job/launch_ansibl e_job:75:in `job_template': Job Template not specified (RuntimeError) [----] E, [2017-09-27T12:13:15.954490 #27111:c2829c] ERROR -- : Q-task_id([resource_action_20000000001132]) Method STDERR: from /ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/Job/lau nch_ansible_job:20:in `main' [----] E, [2017-09-27T12:13:15.954996 #27111:c2829c] ERROR -- : Q-task_id([resource_action_20000000001132]) Method STDERR: from /ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/Job/lau nch_ansible_job:121:in `<main>' [----] I, [2017-09-27T12:13:15.982478 #27111:c3913c] INFO -- : Q-task_id([resource_action_20000000001132]) <AEMethod [/ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/Job/launch_ansible_jo b]> Ending [----] E, [2017-09-27T12:13:15.983298 #27111:c3913c] ERROR -- : Q-task_id([resource_action_20000000001132]) State=<Launch> running raised exception: <Method exited with rc=Unknown RC: [1]> [----] W, [2017-09-27T12:13:15.983487 #27111:c3913c] WARN -- : Q-task_id([resource_action_20000000001132]) Error in State=[Launch] New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/dd1215d37906f6fd7ee757cdd5510a019bfa7039 commit dd1215d37906f6fd7ee757cdd5510a019bfa7039 Author: James Wong <jwong> AuthorDate: Thu May 17 18:58:09 2018 -0400 Commit: James Wong <jwong> CommitDate: Thu May 17 18:58:09 2018 -0400 Integrate with external Tower Workflow https://bugzilla.redhat.com/show_bug.cgi?id=1468339 app/models/configuration_workflow.rb | 5 + app/models/manageiq/providers/automation_manager.rb | 2 + app/models/manageiq/providers/automation_manager/configuration_workflow.rb | 3 + app/models/manageiq/providers/embedded_ansible/automation_manager.rb | 1 + app/models/manageiq/providers/embedded_ansible/automation_manager/configuration_workflow.rb | 3 + app/models/manageiq/providers/embedded_automation_manager/configuration_workflow.rb | 2 + app/models/manageiq/providers/external_automation_manager.rb | 1 + app/models/manageiq/providers/external_automation_manager/configuration_workflow.rb | 2 + app/models/manager_refresh/inventory/automation_manager.rb | 10 + app/models/manager_refresh/inventory/core.rb | 8 + spec/factories/configuration_script.rb | 1 + spec/factories/ext_management_system.rb | 7 + 12 files changed, 45 insertions(+) New commit detected on ManageIQ/manageiq-providers-ansible_tower/master: https://github.com/ManageIQ/manageiq-providers-ansible_tower/commit/4eb455c217c51075d26916a4322358a087643107 commit 4eb455c217c51075d26916a4322358a087643107 Author: James Wong <webpotent> AuthorDate: Thu May 17 18:56:56 2018 -0400 Commit: James Wong <webpotent> CommitDate: Thu May 17 18:56:56 2018 -0400 Integrate with Tower Workflow https://bugzilla.redhat.com/show_bug.cgi?id=1468339 app/models/manageiq/providers/ansible_tower/automation_manager.rb | 1 + app/models/manageiq/providers/ansible_tower/automation_manager/configuration_workflow.rb | 5 + app/models/manageiq/providers/ansible_tower/shared/automation_manager/configuration_workflow.rb | 31 + app/models/manageiq/providers/ansible_tower/shared/inventory/collector/automation_manager.rb | 4 + app/models/manageiq/providers/ansible_tower/shared/inventory/parser/automation_manager.rb | 11 + app/models/manageiq/providers/ansible_tower/shared/inventory/persister/automation_manager.rb | 1 + 6 files changed, 53 insertions(+) Following BZs are created to track works in different components: Backend: https://bugzilla.redhat.com/show_bug.cgi?id=1590440 UI: https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Automate: https://bugzilla.redhat.com/show_bug.cgi?id=1590975 A github issue created for discussion: https://github.com/ManageIQ/manageiq/issues/17441 New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/f49927f088b3dc7b1f72fba71ba70e330736cfa1 commit f49927f088b3dc7b1f72fba71ba70e330736cfa1 Author: L Galis <lgalis> AuthorDate: Tue Jun 26 13:21:39 2018 -0400 Commit: L Galis <lgalis> CommitDate: Tue Jun 26 13:21:39 2018 -0400 Changes to use new subclass to show 'Workflow' & 'Job' templates in UI Reverted some of the changes that were made to use https://github.com/ManageIQ/manageiq/pull/17580 and adjusted code to use subclass in https://github.com/ManageIQ/manageiq/pull/17659 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339 app/controllers/automation_manager_controller.rb | 20 +- app/controllers/catalog_controller.rb | 6 +- app/controllers/mixins/manager_controller_mixin.rb | 2 +- app/decorators/configuration_script_decorator.rb | 5 + app/decorators/manageiq/providers/ansible_tower/automation_manager/configuration_workflow_decorator.rb | 4 - app/helpers/application_helper.rb | 10 +- app/helpers/application_helper/toolbar/configuration_script_center.rb | 4 +- app/presenters/tree_builder_automation_manager_configuration_scripts.rb | 4 +- app/views/layouts/print/textual_summary.html.haml | 2 +- product/views/ConfigurationScript.yaml | 82 + product/views/ConfigurationScriptBase.yaml | 82 - spec/controllers/automation_manager_controller_spec.rb | 2 +- 12 files changed, 111 insertions(+), 112 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/661b78943c74e8533f268350674a570b5ba87b9a commit 661b78943c74e8533f268350674a570b5ba87b9a Author: Harpreet Kataria <hkataria> AuthorDate: Tue Jul 10 11:07:08 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 10 11:07:08 2018 -0400 Changes to use new subclass to show 'Workflow' & 'Job' templates in UI Reverted some of the changes that were made to use https://github.com/ManageIQ/manageiq/pull/17580 and adjusted code to use subclass in https://github.com/ManageIQ/manageiq/pull/17720 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339 app/controllers/application_controller/tags.rb | 2 +- app/controllers/automation_manager_controller.rb | 2 +- app/views/layouts/print/textual_summary.html.haml | 2 +- spec/controllers/automation_manager_controller_spec.rb | 2 +- spec/presenters/tree_node/configuration_script_base_spec.rb | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/26ae0c96ed7402006931545a8dce18578ad767be commit 26ae0c96ed7402006931545a8dce18578ad767be Author: Harpreet Kataria <hkataria> AuthorDate: Tue Jul 31 15:43:43 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 31 15:43:43 2018 -0400 addressed rubocop warnings. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339 app/controllers/automation_manager_controller.rb | 18 +- app/controllers/catalog_controller.rb | 19 +- app/views/automation_manager/explorer.html.haml | 2 +- 3 files changed, 20 insertions(+), 19 deletions(-) Now that we have 3 separate BZs (Automate, UI and Backend) per Comment 20, this BZ seems to be a placeholder. Since all 3 BZs are in ON_QA now, moving this to ON_QA as well. Verified in 5.10.0.16 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0212 |