Bug 1590441 - [RFE][L-8] Integration with external Ansible Tower Workflows - UI
Summary: [RFE][L-8] Integration with external Ansible Tower Workflows - UI
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: MVP
: 5.10.0
Assignee: Harpreet Kataria
QA Contact: Nandini Chandra
URL:
Whiteboard:
Depends On: 1590440
Blocks: 1468339 1597402
TreeView+ depends on / blocked
 
Reported: 2018-06-12 15:13 UTC by James Wong
Modified: 2019-02-07 23:03 UTC (History)
12 users (show)

Fixed In Version: 5.10.0.11
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1590440
: 1590975 (view as bug list)
Environment:
Last Closed: 2019-02-07 23:03:07 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:0212 0 None None None 2019-02-07 23:03:23 UTC

Description James Wong 2018-06-12 15:13:31 UTC
This is to track the UI work for the RFE: Integration with external Ansible Tower Workflows

Comment 4 CFME Bot 2018-08-02 11:27:27 UTC
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/96b82838bf5bcab03ef237dfc111dd3b938b8255
commit 96b82838bf5bcab03ef237dfc111dd3b938b8255
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Jun 13 16:28:39 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Jun 13 16:28:39 2018 -0400

    Show Configuration Workflows in UI

    Changes to show list of Job Templates and Configuration Workflows in existing UI under Automation/Ansible Tower/Explorer in Templates Accordion.

    https://bugzilla.redhat.com/show_bug.cgi?id=1590441

 app/controllers/automation_manager_controller.rb | 36 +-
 app/decorators/manageiq/providers/ansible_tower/automation_manager/configuration_workflow_decorator.rb | 11 +
 app/presenters/tree_builder.rb | 1 +
 app/presenters/tree_builder_automation_manager_configuration_scripts.rb | 6 +-
 app/presenters/tree_node/configuration_script_base.rb | 2 +-
 product/views/ConfigurationScriptBase.yaml | 82 +
 product/views/ManageIQ_Providers_AnsibleTower_AutomationManager_ConfigurationScript.yaml | 82 -
 7 files changed, 117 insertions(+), 103 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/64345afda1edcac323c20f73449aeca98950fd13
commit 64345afda1edcac323c20f73449aeca98950fd13
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jun 22 12:33:33 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jun 22 12:33:33 2018 -0400

    Further changes to update titles on screen and show toolbar buttons

    - Further changes to update titles on screen and show toolbar buttons when Workflow Template record is selected, and render correct textual summary when printing summary to PDF.
    - Changes to Catalo Items editor to show grouping in the Template drop down.

    https://bugzilla.redhat.com/show_bug.cgi?id=1590441

 app/controllers/automation_manager_controller.rb | 7 +-
 app/controllers/catalog_controller.rb | 17 +-
 app/helpers/application_helper/toolbar/x_configuration_script_center.rb | 4 +-
 app/views/automation_manager/explorer.html.haml | 2 +-
 app/views/catalog/_form_basic_info.html.haml | 5 +-
 app/views/catalog/_sandt_tree_show.html.haml | 2 +-
 app/views/layouts/print/textual_summary.html.haml | 2 +-
 7 files changed, 28 insertions(+), 11 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/f49927f088b3dc7b1f72fba71ba70e330736cfa1
commit f49927f088b3dc7b1f72fba71ba70e330736cfa1
Author:     L Galis <lgalis>
AuthorDate: Tue Jun 26 13:21:39 2018 -0400
Commit:     L Galis <lgalis>
CommitDate: Tue Jun 26 13:21:39 2018 -0400

    Changes to use new subclass to show 'Workflow' & 'Job' templates in UI

    Reverted some of the changes that were made to use https://github.com/ManageIQ/manageiq/pull/17580 and adjusted code to use subclass in https://github.com/ManageIQ/manageiq/pull/17659

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

 app/controllers/automation_manager_controller.rb | 20 +-
 app/controllers/catalog_controller.rb | 6 +-
 app/controllers/mixins/manager_controller_mixin.rb | 2 +-
 app/decorators/configuration_script_decorator.rb | 5 +
 app/decorators/manageiq/providers/ansible_tower/automation_manager/configuration_workflow_decorator.rb | 4 -
 app/helpers/application_helper.rb | 10 +-
 app/helpers/application_helper/toolbar/configuration_script_center.rb | 4 +-
 app/presenters/tree_builder_automation_manager_configuration_scripts.rb | 4 +-
 app/views/layouts/print/textual_summary.html.haml | 2 +-
 product/views/ConfigurationScript.yaml | 82 +
 product/views/ConfigurationScriptBase.yaml | 82 -
 spec/controllers/automation_manager_controller_spec.rb | 2 +-
 12 files changed, 111 insertions(+), 112 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/661b78943c74e8533f268350674a570b5ba87b9a
commit 661b78943c74e8533f268350674a570b5ba87b9a
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Jul 10 11:07:08 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jul 10 11:07:08 2018 -0400

    Changes to use new subclass to show 'Workflow' & 'Job' templates in UI

    Reverted some of the changes that were made to use https://github.com/ManageIQ/manageiq/pull/17580 and adjusted code to use subclass in https://github.com/ManageIQ/manageiq/pull/17720

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

 app/controllers/application_controller/tags.rb | 2 +-
 app/controllers/automation_manager_controller.rb | 2 +-
 app/views/layouts/print/textual_summary.html.haml | 2 +-
 spec/controllers/automation_manager_controller_spec.rb | 2 +-
 spec/presenters/tree_node/configuration_script_base_spec.rb | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/26ae0c96ed7402006931545a8dce18578ad767be
commit 26ae0c96ed7402006931545a8dce18578ad767be
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Jul 31 15:43:43 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jul 31 15:43:43 2018 -0400

    addressed rubocop warnings.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590441
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468339

 app/controllers/automation_manager_controller.rb | 18 +-
 app/controllers/catalog_controller.rb | 19 +-
 app/views/automation_manager/explorer.html.haml | 2 +-
 3 files changed, 20 insertions(+), 19 deletions(-)

Comment 7 Greg Blomquist 2018-08-06 14:32:59 UTC
Modeling/backend changes: https://github.com/ManageIQ/manageiq/pull/17720

Comment 9 CFME Bot 2018-08-07 07:58:07 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/75a12c4616d8c0b73162dcea1c0e4411977191c6
commit 75a12c4616d8c0b73162dcea1c0e4411977191c6
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Aug  3 13:19:08 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Aug  3 13:19:08 2018 -0400

    Addressed codeclimate warning

    Addressed codeclimate warning Method available_job_templates has a Cognitive Complexity of 6

    Follow up fix for changes requested in https://github.com/ManageIQ/manageiq-ui-classic/pull/4138#pullrequestreview-142958559

    https://bugzilla.redhat.com/show_bug.cgi?id=1590441

 app/controllers/catalog_controller.rb | 12 +-
 1 file changed, 8 insertions(+), 4 deletions(-)

Comment 10 Nandini Chandra 2018-09-25 16:56:36 UTC
Verified in 5.10.0.16

Comment 11 errata-xmlrpc 2019-02-07 23:03:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0212


Note You need to log in before you can comment on or make changes to this bug.