Bug 1468844

Summary: julia: FTBFS in Rawhide due to libgit2 0.26.x
Product: [Fedora] Fedora Reporter: Igor Gnatenko <ignatenko>
Component: juliaAssignee: Milan Bouchet-Valat <nalimilan>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: nalimilan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-09 17:34:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Igor Gnatenko 2017-07-08 20:14:32 UTC
https://github.com/JuliaLang/julia/pull/22614

I suppose this PR will be enough, but check please. Rawhide has 0.26.0 since today.

Comment 1 Milan Bouchet-Valat 2017-07-08 22:10:06 UTC
I'll try that, but that branch is on the development version of Julia, so it might not backport cleanly. Aren't we supposed to first check that dependencies still build before upgrading to breaking releases of libraries?

Comment 2 Igor Gnatenko 2017-07-08 22:35:49 UTC
(In reply to Milan Bouchet-Valat from comment #1)
> I'll try that, but that branch is on the development version of Julia, so it
> might not backport cleanly. Aren't we supposed to first check that
> dependencies still build before upgrading to breaking releases of libraries?

* It's been almost month since 0.26.0 got released
* Patch is available, but I didn't have time to look at it
* Only one test failed due to updated (upper vs lower case)

P.S. it is clearly applies to v0.6.0

Comment 3 Milan Bouchet-Valat 2017-07-09 17:34:26 UTC
I don't deny that, but even if it had been release for a year, by pushing a breaking release of libgit2 you take the risk of making Julia FTBS for some time. I don't see the advantage of updating libgit2 directly, when we could have patched Julia first to ensure everything is OK. FWIW, the Updates Policy says:
>  A week in advance, notify maintainers who depend on their package
> to rebuild when there are abi/api changes that require rebuilds
> in other packages or offer to do these rebuilds for them.
https://fedoraproject.org/wiki/Updates_Policy

Anyway, I've built a new version after backporting the upstream patch plus a few tweaks.