Bug 1470175

Summary: mariadb library upgrade to 10.2 causes mydns FTBFS
Product: [Fedora] Fedora Reporter: Augusto Caringi <acaringi>
Component: mydnsAssignee: Itamar Reis Peixoto <itamar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, itamar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-21 19:51:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1467297    
Attachments:
Description Flags
Patch to allow compilation of mydns with MariaDB 10.2 none

Description Augusto Caringi 2017-07-12 13:37:07 UTC 
Created attachment 1297014 [details]
Patch to allow compilation of mydns with MariaDB 10.2

Trying to build mydns with the new version of MariaDB 10.2 causes an error:

In file included from named.h:26:0,
                 from main.c:21:
main.c: In function 'cmdline':
../../lib/mydnsutil.h:180:36: error: expected ')' before 'MYSQL_SERVER_VERSION'
 # define  SQL_VERSION_STR "MySQL " MYSQL_SERVER_VERSION
                                    ^

In this new version of MariaDB they introduced a new mariadb_version.h header and mysql.h includes this header instead of mysql_version.h.
But the mysql_version.h is still present.

I'm attaching a patch proposal to fix the problem.

We are tracking all the possible problems regarding this MariaDB upgrade in the bug 1467297.

Copr build: https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/package/mydns/
Comment 1 Adam Williamson 2017-07-21 19:51:56 UTC 
Build done:

https://koji.fedoraproject.org/koji/taskinfo?taskID=20651297

Wasn't able to submit the patch upstream as registration for their bug tracker doesn't seem to be working (claims to be sending you a confirmation mail, never actually did).
Comment 2 Itamar Reis Peixoto 2017-07-21 20:27:33 UTC 
thank you, I will be happy to accept your patch.
Comment 3 Adam Williamson 2017-07-21 20:33:48 UTC 
Now managed to submit an issue upstream with a link to this bug and patch: http://bugs.mydns-ng.com/view.php?id=78