Bug 1470175 - mariadb library upgrade to 10.2 causes mydns FTBFS
mariadb library upgrade to 10.2 causes mydns FTBFS
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: mydns (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Itamar Reis Peixoto
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1467297
  Show dependency treegraph
 
Reported: 2017-07-12 09:37 EDT by Augusto Caringi
Modified: 2017-07-21 16:33 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-21 15:51:56 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to allow compilation of mydns with MariaDB 10.2 (352 bytes, patch)
2017-07-12 09:37 EDT, Augusto Caringi
no flags Details | Diff

  None (edit)
Description Augusto Caringi 2017-07-12 09:37:07 EDT
Created attachment 1297014 [details]
Patch to allow compilation of mydns with MariaDB 10.2

Trying to build mydns with the new version of MariaDB 10.2 causes an error:

In file included from named.h:26:0,
                 from main.c:21:
main.c: In function 'cmdline':
../../lib/mydnsutil.h:180:36: error: expected ')' before 'MYSQL_SERVER_VERSION'
 # define  SQL_VERSION_STR "MySQL " MYSQL_SERVER_VERSION
                                    ^

In this new version of MariaDB they introduced a new mariadb_version.h header and mysql.h includes this header instead of mysql_version.h.
But the mysql_version.h is still present.

I'm attaching a patch proposal to fix the problem.

We are tracking all the possible problems regarding this MariaDB upgrade in the bug 1467297.

Copr build: https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/package/mydns/
Comment 1 Adam Williamson 2017-07-21 15:51:56 EDT
Build done:

https://koji.fedoraproject.org/koji/taskinfo?taskID=20651297

Wasn't able to submit the patch upstream as registration for their bug tracker doesn't seem to be working (claims to be sending you a confirmation mail, never actually did).
Comment 2 Itamar Reis Peixoto 2017-07-21 16:27:33 EDT
thank you, I will be happy to accept your patch.
Comment 3 Adam Williamson 2017-07-21 16:33:48 EDT
Now managed to submit an issue upstream with a link to this bug and patch: http://bugs.mydns-ng.com/view.php?id=78

Note You need to log in before you can comment on or make changes to this bug.