Bug 1470196

Summary: mariadb library upgrade to 10.2 causes perl-DBD-MySQL FTBFS
Product: [Fedora] Fedora Reporter: Honza Horak <hhorak>
Component: perl-DBD-MySQLAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, jplesnik, perl-devel, ppisar
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-DBD-MySQL-4.043-2.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-14 12:46:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1467297    
Attachments:
Description Flags
Proposed patch none

Description Honza Horak 2017-07-12 13:59:05 UTC
Created attachment 1297022 [details]
Proposed patch

Description of problem:
With new version of MariaDB 10.2 we see basically this two separate issues:

dbdimp.c: In function 'mysql_dr_connect':
dbdimp.c:2000:13: error: 'MYSQL {aka struct st_mysql}' has no member named 'reconnect'
       result->reconnect=0;
             ^~

dbdimp.c: In function 'mysql_st_prepare':
dbdimp.c:2779:19: error: 'MYSQL_VERSION_ID' undeclared (first use in this function); did you mean 'MYSQL_VERSION_5_0'?
                   MYSQL_VERSION_ID, statement);
                   ^~~~~~~~~~~~~~~~
                   MYSQL_VERSION_5_0
dbdimp.c:2779:19: note: each undeclared identifier is reported only once for each function it appears in

The attached patch should fix the FTBFS issue.

Comment 1 Adam Williamson 2017-07-14 02:16:34 UTC
There seems to be a rather complex debate going on about a PR to fix the MariaDB compatibility (while not losing MySQL compatibility) upstream:

https://github.com/perl5-dbi/DBD-mysql/pull/133

Any thoughts on that? They seem to have identified some further issues, but you might have a better handle on the versioning bits than they do...