Bug 1470196 - mariadb library upgrade to 10.2 causes perl-DBD-MySQL FTBFS
Summary: mariadb library upgrade to 10.2 causes perl-DBD-MySQL FTBFS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-DBD-MySQL
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1467297
TreeView+ depends on / blocked
 
Reported: 2017-07-12 13:59 UTC by Honza Horak
Modified: 2017-07-14 12:47 UTC (History)
4 users (show)

Fixed In Version: perl-DBD-MySQL-4.043-2.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-14 12:46:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed patch (1.33 KB, patch)
2017-07-12 13:59 UTC, Honza Horak
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
CPAN 122429 0 None None None 2017-07-14 12:46:37 UTC
CPAN 122431 0 None None None 2017-07-14 12:47:37 UTC
Github perl5-dbi DBD-mysql issues 139 0 None None None 2017-07-14 06:17:53 UTC
Github perl5-dbi DBD-mysql pull 133 0 None None None 2017-07-14 06:16:02 UTC

Description Honza Horak 2017-07-12 13:59:05 UTC
Created attachment 1297022 [details]
Proposed patch

Description of problem:
With new version of MariaDB 10.2 we see basically this two separate issues:

dbdimp.c: In function 'mysql_dr_connect':
dbdimp.c:2000:13: error: 'MYSQL {aka struct st_mysql}' has no member named 'reconnect'
       result->reconnect=0;
             ^~

dbdimp.c: In function 'mysql_st_prepare':
dbdimp.c:2779:19: error: 'MYSQL_VERSION_ID' undeclared (first use in this function); did you mean 'MYSQL_VERSION_5_0'?
                   MYSQL_VERSION_ID, statement);
                   ^~~~~~~~~~~~~~~~
                   MYSQL_VERSION_5_0
dbdimp.c:2779:19: note: each undeclared identifier is reported only once for each function it appears in

The attached patch should fix the FTBFS issue.

Comment 1 Adam Williamson 2017-07-14 02:16:34 UTC
There seems to be a rather complex debate going on about a PR to fix the MariaDB compatibility (while not losing MySQL compatibility) upstream:

https://github.com/perl5-dbi/DBD-mysql/pull/133

Any thoughts on that? They seem to have identified some further issues, but you might have a better handle on the versioning bits than they do...


Note You need to log in before you can comment on or make changes to this bug.