Bug 1470358 (php-jms-serializer)
| Summary: | Review Request: php-jms-serializer - Library for (de-)serializing data of any complexity | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-09-28 16:55:08 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1458576, 1483262 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Shawn Iwinski
2017-07-12 19:50:45 UTC
DEBUG util.py:450: No matching package to install: 'php-JMSParser >= 1.0.0-7' DEBUG util.py:450: No matching package to install: 'php-composer(jms/metadata) >= 1.6.0' DEBUG util.py:450: No matching package to install: 'php-composer(jms/metadata) < 2.0' DEBUG util.py:450: No matching package to install: 'php-composer(jms/parser-lib) < 2.0' DEBUG util.py:450: No matching package to install: 'php-composer(phpcollection/phpcollection) >= 0.5.0' DEBUG util.py:450: No matching package to install: 'php-composer(phpcollection/phpcollection) < 1.0' Missing packages in rawhide... probably we need a successful "compose" Update to 1.8.1 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/c95392c98f697c8df3ed110ef44872581cd335cf/php-jms-serializer/php-jms-serializer.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-jms-serializer-1.8.1-1.fc26.src.rpm Still same error... :( Looking at https://src.fedoraproject.org/rpms/php-JMSParser/c/2ce3bc7de8cef3c4873f53f305109b37523d6d87?branch=master https://src.fedoraproject.org/rpms/php-Metadata/c/9ce5dab2be8eb460b7d47d054207e6739338fa02?branch=master https://src.fedoraproject.org/rpms/php-PhpCollection/c/576548c4d44a27b0091f0b06f1a9edfee0874498?branch=master These 3 packages have been retired so are blocked, and don't go in the repository. You have to have them unblocked first. Despite a rawhide repository update (Fri, 25 Aug 2017 13:26:56 +0200) Missing packages sare still not there Ex: https://rpms.remirepo.net/rpmphp/zoom.php?rpm=php-PhpCollection Scratch builds: * rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=22013039 * f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=22013041 * f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=22013043 * f25: https://koji.fedoraproject.org/koji/taskinfo?taskID=22013045 Sadly, the needed packages are still not available in the repository, including rawhide... BTW I will run the review against local packages, and let you manage this issue (perhaps only have to wait for a new "compose") Minor test failure, only with PHP 5.6 and Twig 2 (ok with other PHP versions or with Twig 1) There were 2 errors: 1) JMS\Serializer\Tests\Twig\SerializerExtensionTest::testSerialize Argument 1 passed to Twig_Filter::__construct() must be an instance of string, string given, called in /dev/shm/extras/BUILDROOT/php-jms-serializer-1.8.1-1.fc25.remi.x86_64/usr/share/php/JMS/Serializer/Twig/SerializerExtension.php on line 46 and defined /usr/share/php/Twig2/Filter.php:35 /dev/shm/extras/BUILDROOT/php-jms-serializer-1.8.1-1.fc25.remi.x86_64/usr/share/php/JMS/Serializer/Twig/SerializerExtension.php:46 /dev/shm/extras/BUILD/serializer-ce65798f722c836f16d5d7d2e3ca9d21e0fb4331/tests/Twig/SerializerExtensionTest.php:40 2) JMS\Serializer\Tests\Twig\SerializerExtensionTest::testRuntimeSerializerExtension Argument 1 passed to Twig_Filter::__construct() must be an instance of string, string given, called in /dev/shm/extras/BUILD/serializer-ce65798f722c836f16d5d7d2e3ca9d21e0fb4331/tests/Twig/SerializerExtensionTest.php on line 70 and defined /usr/share/php/Twig2/Filter.php:35 /dev/shm/extras/BUILD/serializer-ce65798f722c836f16d5d7d2e3ca9d21e0fb4331/tests/Twig/SerializerExtensionTest.php:70 Notice: "php56" should be last case of the loop, as it disable some tests (sed) BTW, not a blocker as Fedora only have PHP 7 Simply, Twig 2 is not compatible with PHP 5 ;) (could be tweak in autoloader, but perhaps doesn't worth the work for Fedora) Created attachment 1329367 [details]
phpci.log
phpCompatInfo version 5.0.8 DB version 1.23.0 built Jul 17 2017
20:33:14 CEST static analyze results
Created attachment 1329368 [details]
phpci.log
Created attachment 1329369 [details]
review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1470358 -L /dev/shm/extras/RPMS/noarch
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Built with local dependencies:
/dev/shm/extras/RPMS/noarch/php-PhpCollection-0.5.0-4.fc25.remi.noarch.rpm
/dev/shm/extras/RPMS/noarch/php-JMSParser-1.0.0-12.fc25.remi.noarch.rpm
[x]: Package complies to the Packaging Guidelines === APPROVED === THANKS! https://pagure.io/releng/fedora-scm-requests/issue/1535 https://pagure.io/releng/fedora-scm-requests/issue/1536 https://pagure.io/releng/fedora-scm-requests/issue/1537 https://pagure.io/releng/fedora-scm-requests/issue/1538 FYI bug 1483262 is up next :) (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-jms-serializer php-jms-serializer-1.8.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6aea60dd2a php-jms-serializer-1.8.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4d7812e2e php-jms-serializer-1.8.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a5510eed4b php-jms-serializer-1.8.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a5510eed4b php-jms-serializer-1.8.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4d7812e2e php-jms-serializer-1.8.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6aea60dd2a php-jms-serializer-1.8.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. php-jms-serializer-1.8.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. php-jms-serializer-1.8.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |