Bug 1470358 - (php-jms-serializer) Review Request: php-jms-serializer - Library for (de-)serializing data of any complexity
Review Request: php-jms-serializer - Library for (de-)serializing data of any...
Status: ASSIGNED
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Remi Collet
Fedora Extras Quality Assurance
:
Depends On:
Blocks: phpdoc_v2_tracking phpdoc
  Show dependency treegraph
 
Reported: 2017-07-12 15:50 EDT by Shawn Iwinski
Modified: 2017-09-22 17:16 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
fedora: fedora‑review+


Attachments (Terms of Use)
phpci.log (2.70 KB, text/plain)
2017-09-22 01:32 EDT, Remi Collet
no flags Details
phpci.log (74.98 KB, text/plain)
2017-09-22 01:33 EDT, Remi Collet
no flags Details
review.txt (8.39 KB, text/plain)
2017-09-22 01:34 EDT, Remi Collet
no flags Details

  None (edit)
Description Shawn Iwinski 2017-07-12 15:50:45 EDT
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/f463bb372674e9008c2ad6b11489e442898a73a3/php-jms-serializer/php-jms-serializer.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-jms-serializer-1.7.1-1.fc26.src.rpm

Description:
This library allows you to (de-)serialize data of any complexity. Currently, it
supports XML, JSON, and YAML.

It also provides you with a rich tool-set to adapt the output to your specific
needs.

Built-in features include:
* (De-)serialize data of any complexity; circular references are handled
  gracefully.
* Supports many built-in PHP types (such as dates)
* Integrates with Doctrine ORM, et. al.
* Supports versioning, e.g. for APIs
* Configurable via PHP, XML, YAML, or Doctrine Annotations


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2017-08-09 08:37:53 EDT
DEBUG util.py:450:  No matching package to install: 'php-JMSParser >= 1.0.0-7'
DEBUG util.py:450:  No matching package to install: 'php-composer(jms/metadata) >= 1.6.0'
DEBUG util.py:450:  No matching package to install: 'php-composer(jms/metadata) < 2.0'
DEBUG util.py:450:  No matching package to install: 'php-composer(jms/parser-lib) < 2.0'
DEBUG util.py:450:  No matching package to install: 'php-composer(phpcollection/phpcollection) >= 0.5.0'
DEBUG util.py:450:  No matching package to install: 'php-composer(phpcollection/phpcollection) < 1.0'


Missing packages in rawhide... probably we need a successful  "compose"
Comment 4 Remi Collet 2017-08-26 02:50:14 EDT
Despite a rawhide repository update (Fri, 25 Aug 2017 13:26:56 +0200)

Missing packages sare still not there
Ex: https://rpms.remirepo.net/rpmphp/zoom.php?rpm=php-PhpCollection
Comment 6 Remi Collet 2017-09-22 01:11:46 EDT
Sadly, the needed packages are still not available in the repository, including rawhide...

BTW I will run the review against local packages, and let you manage this issue (perhaps only have to wait for a new "compose")
Comment 7 Remi Collet 2017-09-22 01:19:14 EDT
Minor test failure, only with PHP 5.6 and Twig 2 (ok with other PHP versions or with Twig 1)


There were 2 errors:

1) JMS\Serializer\Tests\Twig\SerializerExtensionTest::testSerialize
Argument 1 passed to Twig_Filter::__construct() must be an instance of string, string given, called in /dev/shm/extras/BUILDROOT/php-jms-serializer-1.8.1-1.fc25.remi.x86_64/usr/share/php/JMS/Serializer/Twig/SerializerExtension.php on line 46 and defined

/usr/share/php/Twig2/Filter.php:35
/dev/shm/extras/BUILDROOT/php-jms-serializer-1.8.1-1.fc25.remi.x86_64/usr/share/php/JMS/Serializer/Twig/SerializerExtension.php:46
/dev/shm/extras/BUILD/serializer-ce65798f722c836f16d5d7d2e3ca9d21e0fb4331/tests/Twig/SerializerExtensionTest.php:40

2) JMS\Serializer\Tests\Twig\SerializerExtensionTest::testRuntimeSerializerExtension
Argument 1 passed to Twig_Filter::__construct() must be an instance of string, string given, called in /dev/shm/extras/BUILD/serializer-ce65798f722c836f16d5d7d2e3ca9d21e0fb4331/tests/Twig/SerializerExtensionTest.php on line 70 and defined

/usr/share/php/Twig2/Filter.php:35
/dev/shm/extras/BUILD/serializer-ce65798f722c836f16d5d7d2e3ca9d21e0fb4331/tests/Twig/SerializerExtensionTest.php:70


Notice: "php56" should be last case of the loop, as it disable some tests (sed)

BTW, not a blocker as Fedora only have PHP 7
Comment 8 Remi Collet 2017-09-22 01:29:33 EDT
Simply, Twig 2 is not compatible with PHP 5 ;)
(could be tweak in autoloader, but perhaps doesn't worth the work for Fedora)
Comment 9 Remi Collet 2017-09-22 01:32 EDT
Created attachment 1329367 [details]
phpci.log

phpCompatInfo version 5.0.8 DB version 1.23.0 built Jul 17 2017
     20:33:14 CEST static analyze results
Comment 10 Remi Collet 2017-09-22 01:33 EDT
Created attachment 1329368 [details]
phpci.log
Comment 11 Remi Collet 2017-09-22 01:34 EDT
Created attachment 1329369 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1470358 -L /dev/shm/extras/RPMS/noarch
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Built with local dependencies:
    /dev/shm/extras/RPMS/noarch/php-PhpCollection-0.5.0-4.fc25.remi.noarch.rpm
    /dev/shm/extras/RPMS/noarch/php-JMSParser-1.0.0-12.fc25.remi.noarch.rpm
Comment 12 Remi Collet 2017-09-22 01:35:33 EDT
[x]: Package complies to the Packaging Guidelines


=== APPROVED ===
Comment 14 Shawn Iwinski 2017-09-22 16:08:47 EDT
FYI bug 1483262 is up next :)
Comment 15 Gwyn Ciesla 2017-09-22 17:16:10 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-jms-serializer

Note You need to log in before you can comment on or make changes to this bug.