Bug 1471799

Summary:	gdeploy 2.0.2 should be backward compatible as per cockpit requirements
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	RamaKasturi <knarra>
Component:	gdeploy	Assignee:	Sachidananda Urs <surs>
Status:	CLOSED ERRATA	QA Contact:	RamaKasturi <knarra>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.3	CC:	amukherj, rcyriac, rhinduja, rhs-bugs, smohan, storage-qa-internal
Target Milestone:	---
Target Release:	RHGS 3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	gdeploy-2.0.2-13	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-21 04:52:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1411323, 1417151

Description RamaKasturi 2017-07-17 13:07:26 UTC

Description of problem:
When gdeploy 2.0.2 releases it will break any new installations of RHHI as the script files present in the generated gdeploy conf file points to a location which does not exist. 

Version-Release number of selected component (if applicable):
gdeploy 2.0.2

How reproducible:
Always

Steps to Reproduce:
1. Install RHHI setup using ansible 2.3 and gdeploy 2.0.2
2.
3.

Actual results:
Installation fails and does not proceed further.

Expected results:
Installation should succeed.

Additional info:
This cannot be fixed at RHV layer since there are two releases which are happening RHV 4.1.4 before RHGS 3.3 and RHV 4.1.5 which is after 3.3. 

If we fix plan to fix this bug at 4.1.4 release it will break installation of RHHI since RHGS 3.3 is not released.

If we plan to fix this bug at RHV 4.1.5 release then this will break installation of RHHI before RHV 4.1.5 releases.

This is the reason why we would need to fix this at gdeploy level and hence proposing this as blocker.

Comment 4 Sachidananda Urs 2017-07-19 09:21:53 UTC

This is a spec file change, for now the scripts are copied to both:

/usr/share/gdeploy/scripts and
/usr/share/ansible/gdeploy/scripts

Will remove /usr/share/ansible/gdeploy/scripts in future.

Comment 5 RamaKasturi 2017-07-24 09:42:24 UTC

Moving this bug back as installation fails with error as the script name for 'blacklist_all_disks.sh' has not been changed in cockpit UI. The script can be renamed at a later point of time. For now the script name has to be renamed tp disable-multipath.sh.

Comment 6 RamaKasturi 2017-07-24 10:25:01 UTC

Please rename the script blacklist_all_disks.sh to disable-multipath.sh to meet the cockpit requirements.

Comment 9 RamaKasturi 2017-07-24 12:48:43 UTC

Will verify this bug once the bug https://bugzilla.redhat.com/show_bug.cgi?id=1474350 moves to on_qa.

Comment 10 RamaKasturi 2017-07-31 10:21:59 UTC

Verified and works fine with build gdeploy-2.0.2-14.el7rhgs.noarch

I see that scripts with this version are present in both the paths /usr/share/ansible/gdeploy/scripts and /usr/share/gdeploy/scripts to meet cockpit requirements.

[root@yarrow-nic2 ~]# ls -l /usr/share/ansible/gdeploy/scripts/
total 16
-rwxr-xr-x. 1 root root 1218 Jul 28 16:23 blacklist_all_disks.sh
-rwxr-xr-x. 1 root root  512 Jul 28 16:23 disable-gluster-hooks.sh
-rwxr-xr-x. 1 root root 1218 Jul 28 16:23 disable-multipath.sh
-rwxr-xr-x. 1 root root 3476 Jul 28 16:23 grafton-sanity-check.sh

[root@yarrow-nic2 ~]# ls -l /usr/share/gdeploy/scripts/
total 16
-rwxr-xr-x. 1 root root 1218 Jul 28 16:23 blacklist_all_disks.sh
-rwxr-xr-x. 1 root root  512 Jul 28 16:23 disable-gluster-hooks.sh
-rwxr-xr-x. 1 root root 1218 Jul 28 16:23 disable-multipath.sh
-rwxr-xr-x. 1 root root 3476 Jul 28 16:23 grafton-sanity-check.sh

Comment 12 errata-xmlrpc 2017-09-21 04:52:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2777