Bug 1472748

Summary: Review Request: perl-Tk-FontDialog - Font dialog widget for perl/Tk
Product: [Fedora] Fedora Reporter: Jitka Plesnikova <jplesnik>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Tk-FontDialog-0.18-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-20 08:20:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jitka Plesnikova 2017-07-19 10:47:18 UTC 
Spec URL: https://jplesnik.fedorapeople.org/perl-Tk-FontDialog/perl-Tk-FontDialog.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Tk-FontDialog/perl-Tk-FontDialog-0.18-1.fc27.src.rpm

Description:
This module implements a font dialog widget for perl/Tk.

Fedora Account System Username: jplesnik

This module is required for new version of perl-Config-Model.
Comment 1 Petr Pisar 2017-07-19 12:31:08 UTC 
URL and Source0 addressed are Ok.
Source0 archive (SHA-256: 7c00e8b7213e8b7faf3a0040d46994d7007be4fd501b430d994bc7a8b5806332) is original. Ok.
Summary verified from lib/Tk/FontDialog.pm. Ok.
Description is Ok.
License verified from lib/Tk/FontDialog.pm. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.
All tests pass. Ok.

$ rpmlint perl-Tk-FontDialog.spec ../SRPMS/perl-Tk-FontDialog-0.18-1.fc27.src.rpm ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm 
perl-Tk-FontDialog.spec:30: W: comparison-operator-in-deptoken font(:lang=en)
perl-Tk-FontDialog.src:30: W: comparison-operator-in-deptoken font(:lang=en)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 19 14:15 /usr/share/doc/perl-Tk-FontDialog
-rw-r--r--    1 root    root                     1568 Mar 22 07:10 /usr/share/doc/perl-Tk-FontDialog/Changes
-rw-r--r--    1 root    root                      318 Jul 12  2012 /usr/share/doc/perl-Tk-FontDialog/README
-rw-r--r--    1 root    root                     3866 Jul 19 14:15 /usr/share/man/man3/Tk::FontDialog.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 19 14:15 /usr/share/perl5/vendor_perl/Tk
-rw-r--r--    1 root    root                    24652 Mar 22 07:10 /usr/share/perl5/vendor_perl/Tk/FontDialog.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(Tk) >= 800
      1 perl(Tk::Font)
      1 perl(Tk::HList)
      1 perl(Tk::ItemStyle)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Tk::FontDialog) = 0.18
      1 perl-Tk-FontDialog = 0.18-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27  (https://koji.fedoraproject.org/koji/taskinfo?taskID=20610823). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2017-07-19 22:55:43 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Tk-FontDialog
Comment 3 Jitka Plesnikova 2017-07-20 08:20:39 UTC 
Thank you for the review and the repository.