Bug 1472748 - Review Request: perl-Tk-FontDialog - Font dialog widget for perl/Tk
Review Request: perl-Tk-FontDialog - Font dialog widget for perl/Tk
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-19 06:47 EDT by Jitka Plesnikova
Modified: 2017-07-20 04:20 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-Tk-FontDialog-0.18-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-07-20 04:20:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2017-07-19 06:47:18 EDT
Spec URL: https://jplesnik.fedorapeople.org/perl-Tk-FontDialog/perl-Tk-FontDialog.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Tk-FontDialog/perl-Tk-FontDialog-0.18-1.fc27.src.rpm

Description:
This module implements a font dialog widget for perl/Tk.

Fedora Account System Username: jplesnik@redhat.com

This module is required for new version of perl-Config-Model.
Comment 1 Petr Pisar 2017-07-19 08:31:08 EDT
URL and Source0 addressed are Ok.
Source0 archive (SHA-256: 7c00e8b7213e8b7faf3a0040d46994d7007be4fd501b430d994bc7a8b5806332) is original. Ok.
Summary verified from lib/Tk/FontDialog.pm. Ok.
Description is Ok.
License verified from lib/Tk/FontDialog.pm. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.
All tests pass. Ok.

$ rpmlint perl-Tk-FontDialog.spec ../SRPMS/perl-Tk-FontDialog-0.18-1.fc27.src.rpm ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm 
perl-Tk-FontDialog.spec:30: W: comparison-operator-in-deptoken font(:lang=en)
perl-Tk-FontDialog.src:30: W: comparison-operator-in-deptoken font(:lang=en)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 19 14:15 /usr/share/doc/perl-Tk-FontDialog
-rw-r--r--    1 root    root                     1568 Mar 22 07:10 /usr/share/doc/perl-Tk-FontDialog/Changes
-rw-r--r--    1 root    root                      318 Jul 12  2012 /usr/share/doc/perl-Tk-FontDialog/README
-rw-r--r--    1 root    root                     3866 Jul 19 14:15 /usr/share/man/man3/Tk::FontDialog.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 19 14:15 /usr/share/perl5/vendor_perl/Tk
-rw-r--r--    1 root    root                    24652 Mar 22 07:10 /usr/share/perl5/vendor_perl/Tk/FontDialog.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(Tk) >= 800
      1 perl(Tk::Font)
      1 perl(Tk::HList)
      1 perl(Tk::ItemStyle)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Tk::FontDialog) = 0.18
      1 perl-Tk-FontDialog = 0.18-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Tk-FontDialog-0.18-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27  (https://koji.fedoraproject.org/koji/taskinfo?taskID=20610823). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2017-07-19 18:55:43 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Tk-FontDialog
Comment 3 Jitka Plesnikova 2017-07-20 04:20:39 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.